-
Notifications
You must be signed in to change notification settings - Fork 36
Enable Ubuntu 14.04 beta in travis #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dastergon
wants to merge
76
commits into
master
Choose a base branch
from
travis-trusty-beta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary
Made a strict boolean check for the return value of the Header Preprocessing function
These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)
Moved code to DeletionHandler Service
If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that
…ilation output and added info texts, indicating where the error came from
…ork as expected)" This reverts commit dbaa56d.
This reverts commit 1dbc0d0.
…e compilation" This reverts commit 2fa9595.
Added a change that was hardcoded in the compiler production server (performed by kalintiris somewhere back in time).
Added another autocomple-related value that no longer exists in compilation requests, but is hardcoded in the production compiler server.
4dc3416
to
9c22c78
Compare
At the beta stage, travis-ci does not include preinstalled PHP environment so I am currently installing php from install scripts
7d1c536
to
eefbf70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis' team recently announced that they opened Ubuntu 14.04 as beta.
Since PR #42 is relevant to Ubuntu 14.04 compatibility, I enabled Ubuntu Trusty beta to run tests to its proper environment.
At beta stage, travis-ci does not include pre-installed PHP environment so I am currently installing php from install scripts
Contains PR #42