feat(contract): add on-chain proposal voting system#59
Merged
Conversation
Adds proposals Soroban contract with cast_vote/execute_proposal: double-vote prevention, expiry enforcement, yes>no pass threshold, and cross-contract treasury withdraw on passed proposals. Also adds group_treasury contract gating withdraw behind the proposals contract. 20 tests cover all acceptance criteria. Fixes codebestia#39
|
@Depo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Please resolve the conflicts. |
Adopt upstream/main's refined contract designs: - GroupTreasury: admin-only withdraw, no ProposalsContract coupling - Proposals: finalize_proposal + execute separation, ProposalStatus enum
codebestia
added a commit
that referenced
this pull request
Jun 26, 2026
feat(contract): add on-chain proposal voting system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voting architecture
cast_vote(voter, proposal_id, approve):
execute_proposal(proposal_id):
Storage strategy
Double-vote prevention
Each (proposal_id, voter_address) pair has a dedicated persistent storage entry. Attempting a second vote panics immediately.
Expiry logic
end_time is set at proposal creation as ledger.timestamp + duration_secs. Votes are rejected when timestamp >= end_time; execution requires timestamp >= end_time.
Treasury execution flow
TreasuryClient (defined via contractclient trait interface) is called with (recipient, amount). The treasury contract gates withdraw behind proposals_contract.require_auth(), automatically satisfied by the cross-contract call.
Tests added
Fixes #39