feat: migrate messages content to ciphertext (#173)#249
Merged
codebestia merged 7 commits intoJun 29, 2026
Merged
Conversation
|
@Gabugo-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@Gabugo-tech |
Owner
|
@Gabugo-tech |
added 4 commits
June 29, 2026 19:54
Search is disabled in E2EE environments since the server can no longer read ciphertext. Route returns 501, test updated to match.
- Drop messages_content_search_idx (GIN index on plaintext content) - Add nullable ciphertext column to messages table - Migrate existing content values into ciphertext - Drop plaintext content column
- schema.ts: keep upstream's extended messages table (senderDeviceId, contentType, sequenceNumber, editsMessageId) + messageEnvelopes table - messages.ts: use upstream's serializeMessage with envelope priority and unavailable flag - conversations.ts: use upstream's getConversationRelations(deviceId) and 501 search stub - messaging.ts: use upstream's full send_message/edit_message/typing handlers; fix ask_assistant to pass ciphertext not content
codebestia
requested changes
Jun 29, 2026
Author
There was a problem hiding this comment.
please, i will love if ypu can assign me another issue, i promise to submit pr within some minutes
codebestia
approved these changes
Jun 29, 2026
codebestia
left a comment
codebestia
left a comment
Owner
There was a problem hiding this comment.
LGTM!
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
messagestable and its dependent codebase to use E2E encryptedciphertextpayloads instead of plain textcontent. This prepares the backend for group/MLS single-ciphertext messages where the server can no longer read the contents of messages directly.Changes Made:
apps/backend/src/db/schema.ts):contentcolumn in themessagestable.ciphertextcolumn.messages_content_search_idxGin index that was built for full-text search on plain text content.apps/backend/src/lib/messages.ts):serializeMessageto accept and correctly handleciphertext.apps/backend/src/routes/conversations.ts):GET /:id/searchfull-text search endpoint since the backend can no longer query plain text message content.apps/backend/src/socket/messaging.ts):contentpayloads withciphertextinsend_messageandask_assistantevent handlers.ciphertextinstead ofcontent.Related Issues
messages.ciphertextfor single-blob messages + remove plaintextcontent#173Acceptance Criteria
contentcolumn dropped;ciphertextadded (nullable)serializeMessageno longer references plaintextcloses #173