feat(group-treasury): implement propose_withdraw (#122)#209
Closed
Kayce10 wants to merge 136 commits into
Closed
Conversation
feat(backend): PostgreSQL connection with Drizzle ORM + base schema
feat(backend): SIWS wallet auth with JWT + Socket.IO middleware
feat(backend): real-time messaging via Socket.IO with persistent storage
feat(contracts): TokenTransfer Soroban contract with testnet deploy script
…Works, TechStack, CTA, Footer)
feat(web): landing page for Clicked
ci(backend): format check, lint, and test pipeline
Adds GET /users/:id — requires a valid JWT, returns id/username/avatarUrl plus wallet address/isPrimary pairs; explicit serialization prevents leaking internal fields. Returns 404 for unknown or malformed IDs. Fixes codebestia#10
Adds proposals Soroban contract with cast_vote/execute_proposal: double-vote prevention, expiry enforcement, yes>no pass threshold, and cross-contract treasury withdraw on passed proposals. Also adds group_treasury contract gating withdraw behind the proposals contract. 20 tests cover all acceptance criteria. Fixes codebestia#39
Adds contracts/scripts/deploy_group_treasury.sh mirroring deploy_token_transfer.sh. Validates DEPLOYER_SECRET, ADMIN_ADDRESS, TOKEN_CONTRACT_ID, and INITIAL_MEMBERS (comma-separated) before building, uploading WASM, deploying, and calling initialize. Outputs contract ID and .env setup instructions. Adds GROUP_TREASURY_CONTRACT_ID to .env.example. Fixes codebestia#42
- Add useSocket hook connecting to backend via socket.io-client - Add /app/conversations/[id]/page.tsx with scrollable message thread - Messages grouped by date with day separators - Self messages right-aligned (accent), others left-aligned - Auto-scroll to bottom only when user is already at the bottom - Shows avatar, sender name, content, and timestamp per message
- Add reusable validate(schema) Express middleware returning structured 400s
- Add ChallengeSchema and VerifySchema for auth routes
- Replace manual if(!field) guards in auth.ts with validate middleware
- Structured error format: { error, issues: [{ field, message }] }
- Add supertest + 6 tests covering valid input, missing fields, wrong types
feat: group treasury contract, Makefile, and AI agent chat/fraud endpoints
…oint-10 feat(api): implement GET user profile endpoint
- Add last_read_message_id nullable FK column to conversation_members schema
- Generate migration 0002_greedy_hellion.sql (ALTER TABLE + FK constraint)
- Add message_read Socket.IO event handler with membership + message validation
- Persist lastReadMessageId per userId/conversationId in conversation_members
- Broadcast read_receipt { userId, lastReadMessageId } to conversation room
- Prevent spoofed reads: validates message exists in target conversation
- Add 4 tests covering success, non-member error, invalid message, DB persistence
- Extract Express app into src/app.ts for testability (server start stays in index.ts)
- Add supertest dev dependency for HTTP assertion
- Add 10 integration test cases for POST /auth/challenge and POST /auth/verify:
challenge: valid walletAddress, missing walletAddress, empty body
verify: new user JWT, existing user JWT, expired nonce, invalid sig,
missing fields, empty body, malformed wallet address (Keypair throws)
- All mocks (DB, nonce, Stellar SDK) are offline — no real network or DB required
- 21 tests pass across 3 test files
- Add ioredis dependency and src/lib/redis.ts with graceful null fallback - Cache GET /conversations per userId with 30-second TTL (CONV_CACHE_TTL) - Cache key format: conversations:<userId> - Invalidate cache for all conversation members after send_message - Invalidate cache for all new members after create_conversation - Redis errors silently degrade: requests fall through to DB - Add 5 tests: cache hit skips DB, cache miss writes to Redis, null Redis fallback, Redis error fallback, per-user key format verified
[CONTRACT] Add member management to Group Treasury
created apps/web/src/components/ui/Modal.tsx:1
…mponent add WalletAddress component with copy and explorer link
…ndicator feat: add online presence indicator to DM avatars and member count to…
feat(ui): implement CopyButton with clipboard API and framer-motion t…
Centralize admin check and update backend configuration
- Add WithdrawProposal, ProposalStatus, ProposalCreatedEvent types to storage.rs - Add ProposalCount and WithdrawProposal(u32) DataKey variants - Implement propose_withdraw: validates member, amount > 0, sufficient balance, increments ProposalCount, stores proposal with Pending status and expires_at, auto-adds proposer approval, emits ProposalCreatedEvent, returns proposal ID - Add get_withdraw_proposal helper - Add 5 tests covering all acceptance criteria
|
@Kayce10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Hello @Kayce10 |
Owner
|
Hello @Kayce10 |
Owner
|
Please update your main branch before raising another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
propose_withdraw(env, proposer, to, token, amount, ttl_ledgers) → u32onGroupTreasuryContractas specified in issue #122.Changes
storage.rsProposalStatusenum (Pending,Approved,Rejected,Executed)WithdrawProposalstruct withid,proposer,to,token,amount,approvals,status,expires_atProposalCreatedEventstructDataKey::ProposalCountandDataKey::WithdrawProposal(u32)lib.rspropose_withdraw: verifies proposer is a member,amount > 0, sufficient treasury balance; incrementsProposalCount; stores proposal withstatus = Pendingandexpires_at = ledger.sequence() + ttl_ledgers; auto-adds proposer approval (approvals = 1); emitsProposalCreatedEvent; returns new proposal IDget_withdraw_proposalhelperTests
5 new tests covering all acceptance criteria:
test_propose_withdraw_returns_correct_id— returned ID matches stored proposal's idtest_propose_withdraw_ids_increment— IDs auto-increment correctlytest_propose_withdraw_proposal_fields— all proposal fields set correctly, proposer approval auto-addedtest_propose_withdraw_non_member_panics— non-member call panicstest_propose_withdraw_insufficient_funds_panics— insufficient balance panics with "insufficient funds"All 23 tests pass.
Closes #122