Implement LessonSave mutation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-damian-negru
requested review from
alexandru-calinoiu,
catileptic,
idormenco and
pirvudoru
as code owners
This was referenced Jul 4, 2021
alex-damian-negru
force-pushed
the
feature/implement-lessonSave-mutation
branch
from
25bf8ac to
72d91dd
Compare
alex-damian-negru
changed the title
pirvudoru
requested changes
Jul 5, 2021
|
|
||
| namespace TeacherWorkout.Api.GraphQL.Inputs | ||
| { | ||
| public class LessonSaveInput : InputObjectGraphType |
There was a problem hiding this comment.
Proposal:
Rename this to a LessonSaveInputType
Define a LessonSaveInput
Inherit LessonSaveInputType from InputObjectGraphType
Define the fields using the strongly typed methods to avoid typos.
There was a problem hiding this comment.
Not sure I understand this correctly. Which strongly typed methods are you referring to?
Also, wouldn't it be confusing if a file was named ..InputType? Would it be both an Input & a Type? 🤷♂️
There was a problem hiding this comment.
Made alex-damian-negru#1 to show what i was talknig about.
pirvudoru
changed the title
…ation Reorganize input and output types
pirvudoru
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
Partially closes #6.
How has it been tested?
In
Insomnia, do some mutations over athttp://localhost:5000/graphql(explore the docs for that).