Repository navigation
fix(rpc): restore main typecheck after #4374 + #4398 (settled terminals on the paged index, part of #4272) - #4485
Merged
Merged
Conversation
…he stack merge (part of #4272) The merge of #4374 onto #4425 compiled S05's CompactSettledMessages against the S03a index API: synchronous has() and a generic FrozenIndex no longer exist, so every append threw. Keep the exact membership S05 relied on in a resident key set (its pruning stays carried item 9), and let a retired lane freeze without asking its retired paged store for a cut. (cherry picked from commit e0fea84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4272. Fix main typecheck after #4374 + #4398: S05 (#4374) added
compact-settled-messages.tsagainst the earlier compact index API (has(), genericFrozenIndex); #4398 then replaced that index with the paged settled index, which has neither. The two PRs had no textual conflict, so each passed its own gates, but main at 811ae23 failstsc(TS2339has, TS2315FrozenIndex).This is the same repair already reviewed inside #4439 (commit e0fea84, cherry-picked with -x): S05's exact settled membership is kept in a resident key set instead of querying the index;
session-acceptance-lane.tsreads the settled root through the new shape. Behavior unchanged; everything stays behind the OFF-by-default compact-updates flag.Verification at this head: build exit 0, tsc clean, S05 terminal/epoch/worker/settled regression suites pass (numbers below).