Repository navigation
fix(coding-agent): keep a torn session tail aside and report it once - #4300
Merged
Merged
Conversation
…4295) Set the incomplete bytes aside in <file>.torn-<time>-<id> before cutting them, settle the final line on every persisted open (-c and setSessionFile included, which glued the next append onto a torn tail), and publish one typed session_recovered event per repair.
…he session path (#4295)
code-yeongyu
marked this pull request as ready for review
October 26, 2026 03:03
Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4295
Summary
A torn final session line is backed up before repair, and the person receives one typed recovery notice. Every persisted open path, including continueRecent and setSessionFile, settles the final line before the next append.
Blocking I/O
A damaged-file open, including openAsync, performs synchronous backup open/write/fsync/rename and directory fsync through the existing atomic writer before truncation. The work is bounded to the final segment and occurs once per repaired tail. The sync-call audits do not measure this indirect blocking work.
Regression evidence
Merge order
#4297 -> #4303 -> #4300 -> #4305 last. #4305 overlaps the flushed-append block and rebases after #4300 merges. #4305 carries Fixes #4295; this PR remains Part of #4295.