Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3506.
/btwreplays a copied conversation without main-turn provider hooks and declaresno tools. A completed native search therefore became an undeclared
web_search_callon the next side request.Filter only native web-search replay blocks before budgeting that copied history.
Keep visible assistant content, stored conversation, and normal main-turn replay
unchanged. Side queries do not gain search tools.
CI dependency correction
The static job on
d888ee7exposed an undeclared test-only OpenAI SDK type import.The regression now captures the inspected payload as
Record<string, unknown>.No assertion, fixture, runtime behavior, dependency manifest or lint configuration
changed.
The same
npm run knip:checkproof fails before this correction and exits 0afterward. It retains one pre-existing configuration hint about
./dist/bedrock-provider.js. The owner file passes 27/27, full-outputnpm run checkpasses, and standalone LSP syntax, semantic and suggestiondiagnostics are all empty. Fresh RPC and mock tool-loop QA each pass 4/4,
with sandbox teardown and real authentication unchanged.
Verification
Responses/Codex request carried
web_search_callwithout a tool declaration.The original source-CLI RPC proof then passed all four native-only/mixed-text
scenarios on both APIs. Each side query made one local fake-model request,
preserved visible context and main messages, and omitted native replay.
fe079b4, the owningbtw-side-query.test.tspasses 27/27.npm run buildand the fullnpm run checkboth pass.CLI sandboxes are removed and real authentication is unchanged.
filter is unchanged. Its tracker entry now lives in
changes/unreleased/3523.md, including the package release block. The actualHEAD changelog gate passes.
Fresh CLI QA commands:
The earlier full suite at
2fc890fpassed all script tests and 12 of 13workspaces. Its coding-agent compaction failure was reproduced on unmodified
9aaf1722f. That historical run is not claimed as a green full suite or as afresh full-suite run after this integration.
Evidence receipts
Original targeted source-CLI output:
SHA-256 receipts for retained local evidence:
SHA-256 receipts for the test-only CI correction:
CI
On corrected HEAD
56c4e83affc364051322e2cf3da45477604f8f48, Static checks nowsucceed, clearing the undeclared SDK import failure. The Changelog gate also
succeeds. The final PR rollup has 36 terminal records: fifteen successful,
fifteen skipped, two failed, three cancelled and one neutral.
Workspaces/scripts
passes 656/658 script tests; it and the aggregate
Check and testfail. The twoassertions are the generated
dist/bun/cli.jsknip entry gap and the stalechatgpt-usage-limit.ts#describeChatGptUsageLimitpre-existing-export exception.Both reproduce independently on unmodified main
4d9961eef1c24895f312a074870d8d8143ba81baafter a successful build, with eachfocused owner command exiting 1 and no tracked source changes.
No checker, exception list, assertion or generated file was changed to hide
those failures. The three cancelled jobs remain unverified, and CI is not green.
Upstream READ permission does not permit a rerun.
Independent main control receipts: