Skip to content

MCP presenter: ambiguous legacy origin returns a detailed error instead of the fixed body-free processing error #4248

Closed

Description

@code-yeongyu

S4 — Legacy error envelope differs from the approved exact rule

packages/coding-agent/src/core/extensions/builtin/mcp/elicitation.ts:76-79,98-106 gives the required body-free -32603 / Elicitation processing unavailable for no presenter. But ambiguous legacy origin takes a separate branch at :88-95 with explanatory text and data.reason:"ambiguous_legacy_origin". The approved presenter design (security review round 3, held locally) requires the same fixed no-data envelope for ambiguity too.

Small engine reconciliation PR: normalize only that enforced failure branch and its owner tests (packages/coding-agent/src/core/extensions/builtin/mcp/elicitation.ts, packages/coding-agent/test/mcp/presenter-rpc.test.ts). RED: ambiguous enforced legacy request emits fixed processing error without data. This is a design discrepancy, not evidence that prompt/schema content currently leaks there. If an explicit superseding approval exists, attach it and update the design instead; this investigation did not establish one.

Related: #4197, #4210 (merged), sisyphuslabs/omo-desktop-app#4370. Found while planning the desktop presenter integration.

Activity

  1. code-yeongyu commented on Oct 25, 2026

    @code-yeongyu
    OwnerAuthor

    Fixed by #4250, merged as 23bf99a.

    Evidence at the merged head 1a5d24e:

    • Review CLEAR (Opus 5.5, APPROVE-WITH-NITS; 0 CRITICAL/HIGH/MEDIUM). Its two LOWs are tracked in Follow-up: #4250 review LOWs (superseded 4210 fragment wording, dense legacy presenter test) #4279.
    • Merge-gate dry run: MERGE_OK_DRY code-yeongyu/senpi#4250 at 1a5d24e721 base=main via=exact-head.
    • CI green at that head; static receipt (install, check, typecheck, changes, build) filed.
    • Behaviour: an ambiguous legacy origin now answers with a body-free processing error, as the spec requires when no human or presenter can answer, instead of a coded explanatory error.
  2. added a commit that references this issue on Oct 26, 2026
    758547d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions