fix(test): update model ID expectations to match transformed format#3361
Open
code-yeongyu wants to merge 1 commit intodevfrom
Open
fix(test): update model ID expectations to match transformed format#3361code-yeongyu wants to merge 1 commit intodevfrom
code-yeongyu wants to merge 1 commit intodevfrom
Conversation
resolveModelFromChain() calls transformModelForProvider() which converts claude-opus-4-6 to claude-opus-4.6 for the anthropic provider. The test expectations in generate-omo-config.test.ts were not updated to match this transformed output. Fixes CI failure on dev (2 tests in generate-omo-config.test.ts)
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Test-only change updating expectations to match model ID normalization logic, fixing broken CI tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
devhas been failing (4+ consecutive failures) due to 2 test failures ingenerate-omo-config.test.ts.Root Cause
resolveModelFromChain()infallback-chain-resolution.tscallstransformModelForProvider()which convertsclaude-opus-4-6→claude-opus-4.6for theanthropicprovider. The test expectations weren't updated to match this transformed output.Changes
Updated 3 assertions in 2 tests:
"anthropic/claude-opus-4-6"→"anthropic/claude-opus-4.6"Testing
bun test src/cli/config-manager/generate-omo-config.test.ts→ 7 pass / 0 failbun run typecheck→ cleanbun test src/cli/config-manager/→ 44 pass / 0 failSummary by cubic
Fix CI by updating test expectations to match the provider-transformed Anthropic model ID format (
claude-opus-4.6instead ofclaude-opus-4-6). This resolves two failing tests ondev.src/cli/config-manager/generate-omo-config.test.tsto expect "anthropic/claude-opus-4.6".resolveModelFromChain()→transformModelForProvider().Written for commit f7d8c90. Summary will update on new commits.