fix(delegate-task): apply getAgentConfigKey normalization to isPlanAgent#3330
Open
codeg-dev wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(delegate-task): apply getAgentConfigKey normalization to isPlanAgent#3330codeg-dev wants to merge 1 commit intocode-yeongyu:devfrom
codeg-dev wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
isPlanFamily was already fixed to normalize display names via getAgentConfigKey, but isPlanAgent still used raw agentName.toLowerCase() without normalization. Apply the same fix to isPlanAgent for consistency. Also fixes test title: 'returns true for planner' was describing the OLD includes-based behavior (the bug), but the assertion already expected false. Add regression tests covering Metis/Momus/Atlas display names for both functions. Fixes code-yeongyu#3312
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Standardizes agent name normalization using getAgentConfigKey to ensure consistency and correct matching of display names, supported by new regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPlanFamilywas already fixed (in a previous commit) to normalize display names viagetAgentConfigKey(), butisPlanAgentstill used rawagentName.toLowerCase()without normalization.This PR applies the same fix to
isPlanAgentfor consistency and correctness.Changes
src/tools/delegate-task/constants.tsisPlanAgent: normalizeagentNamethroughgetAgentConfigKey()before comparison (same asisPlanFamily)src/tools/delegate-task/tools.test.tsfalse. Corrected to "returns false for 'planner' (no longer matches via substring)"isPlanAgentwith Metis/Momus/Atlas display names (all should returnfalse)isPlanFamilywith Metis/Momus/Atlas display names (all should returnfalse)Root Cause (from #3312)
Four agents have "(Plan ...)" or "- Plan ..." in their display names:
Without
getAgentConfigKey()normalization, display names containing "plan" as a substring could produce false-positives, and display names for legitimate plan-family agents (prometheus) would fail to match.Testing
Fixes #3312
Summary by cubic
Normalize agent names in isPlanAgent using getAgentConfigKey to avoid display-name mismatches and keep behavior consistent with isPlanFamily. Fixes #3312.
Written for commit 23d1257. Summary will update on new commits.