test(doctor): cover custom provider config regression#3294
Open
kilhyeonjun wants to merge 1 commit intocode-yeongyu:devfrom
Open
test(doctor): cover custom provider config regression#3294kilhyeonjun wants to merge 1 commit intocode-yeongyu:devfrom
kilhyeonjun wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Refs code-yeongyu#3293 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Only adds a regression test case to an existing test file. No production code changes, so zero risk of functional regressions.
Contributor
Author
|
Clarifying the intent of this PR since my previous comment was formatted poorly: This PR is only for regression coverage, not for reintroducing the doctor fix itself. The core fix already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencode.jsoncheckConfig()does not reportModel override uses unavailable providerfor a valid custom provider such askiroValidation
bun test src/cli/doctor/checks/config.test.ts src/cli/doctor/checks/model-resolution-cache.test.ts src/cli/doctor/checks/model-resolution.test.ts --bailSummary by cubic
Add a regression test to ensure custom providers declared in
opencode.jsonare recognized by the doctor config check and not flagged as unavailable. VerifiescheckConfig()accepts a valid provider likekiro, guarding against the false positive reported in #3293.Written for commit 02d64e4. Summary will update on new commits.