Skip to content

test(doctor): cover custom provider config regression#3294

Open
kilhyeonjun wants to merge 1 commit intocode-yeongyu:devfrom
kilhyeonjun:fix/doctor-custom-provider-regression
Open

test(doctor): cover custom provider config regression#3294
kilhyeonjun wants to merge 1 commit intocode-yeongyu:devfrom
kilhyeonjun:fix/doctor-custom-provider-regression

Conversation

@kilhyeonjun
Copy link
Copy Markdown
Contributor

@kilhyeonjun kilhyeonjun commented Apr 10, 2026

Summary

Validation

  • bun test src/cli/doctor/checks/config.test.ts src/cli/doctor/checks/model-resolution-cache.test.ts src/cli/doctor/checks/model-resolution.test.ts --bail

Summary by cubic

Add a regression test to ensure custom providers declared in opencode.json are recognized by the doctor config check and not flagged as unavailable. Verifies checkConfig() accepts a valid provider like kiro, guarding against the false positive reported in #3293.

Written for commit 02d64e4. Summary will update on new commits.

Refs code-yeongyu#3293

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Only adds a regression test case to an existing test file. No production code changes, so zero risk of functional regressions.

@kilhyeonjun
Copy link
Copy Markdown
Contributor Author

Clarifying the intent of this PR since my previous comment was formatted poorly:

This PR is only for regression coverage, not for reintroducing the doctor fix itself.

The core fix already landed on dev in #3200, but the released v3.16.0 binary still reproduces the false-positive reported in #3293. This test makes sure checkConfig() continues to treat custom providers declared in opencode.json as valid going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant