Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nest files with timestamp for plugin runners #929

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Feb 3, 2025

closes #930
part of #888
part of #695
Additional changes:

  • makes sure all the logs from runner process will appear in CLI via logger log
  • adds some handy logs that help identify or reproduce issues
  • adds --no-progress --verbose to "code-pushup" command "node packages/cli/src/index.ts" that runns CP collection on this repo as it is very annoying to not have logs considering how frequently it is it breaks during PRs

Copy link

github-actions bot commented Feb 4, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit e4f98fa with source commit 29cf02a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 52 ↓ −1.7
Code coverage 🟢 91 🟢 91 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 9 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 52 ↓ −1.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.1 s 🟨 5.5 s ↑ +7 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.5 s ↑ +2.9 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↑ +0.8 %
Lighthouse Total Blocking Time 🟥 4,030 ms 🟥 4,800 ms ↑ +19.1 %
Lighthouse Time to Interactive 🟥 14.2 s 🟥 14.6 s ↑ +2.8 %
JSDoc coverage Functions coverage 🟥 439 undocumented functions 🟥 439 undocumented functions  +0 %
Code coverage Function coverage 🟩 93.1 % 🟩 93 % ↓ −0.1 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.7 % ↓ −0.1 %
JSDoc coverage Types coverage 🟥 198 undocumented types 🟥 199 undocumented types ↑ +0.5 %
JSDoc coverage Variables coverage 🟥 200 undocumented variables 🟥 195 undocumented variables ↓ −2.5 %
Code coverage Branch coverage 🟨 85.9 % 🟨 85.9 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 13.7 s 🟥 16.3 s ↑ +19.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 6.5 s 🟥 7.2 s ↑ +10.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,826 KiB 🟩 Total size was 1,826 KiB ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 230 ms ↑ +65.6 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 780 ms 🟥 Potential savings of 870 ms ↑ +11.4 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 440 ms ↑ +6.6 %
Lighthouse Max Potential First Input Delay 🟥 1,760 ms 🟥 1,780 ms ↑ +1.4 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 30 ms ↑ +8 %
Lighthouse Avoid non-composited animations 🟩 10 animated elements found 🟩 0 ↓ −100 %

574 other audits are unchanged.

@vmasek vmasek force-pushed the runner-config-and-output branch 3 times, most recently from 2c55fbc to e313d2f Compare February 4, 2025 10:21
@github-actions github-actions bot removed the 🧩 cli label Feb 4, 2025
@vmasek vmasek force-pushed the runner-config-and-output branch 3 times, most recently from a1c3aa4 to 5e38156 Compare February 4, 2025 16:46
@vmasek vmasek marked this pull request as ready for review February 4, 2025 17:32
matejchalk
matejchalk previously approved these changes Feb 5, 2025
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this 🙂

Left some suggestions, but none of them are a blocker.

packages/plugin-eslint/src/bin.ts Show resolved Hide resolved
packages/plugin-eslint/src/lib/runner.integration.test.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/execute-process.ts Outdated Show resolved Hide resolved
project.json Show resolved Hide resolved
@vmasek vmasek force-pushed the runner-config-and-output branch 4 times, most recently from 4f83a09 to de3e55e Compare February 5, 2025 17:10
@vmasek vmasek force-pushed the runner-config-and-output branch from de3e55e to 4d46814 Compare February 5, 2025 17:22
@vmasek vmasek force-pushed the runner-config-and-output branch from 4d46814 to 2c5af87 Compare February 10, 2025 12:59
@vmasek vmasek enabled auto-merge (rebase) February 10, 2025 22:29
@vmasek vmasek force-pushed the runner-config-and-output branch from 142f160 to 3a50ad5 Compare February 11, 2025 20:15
@vmasek vmasek merged commit 0f8f66f into main Feb 11, 2025
16 checks passed
@vmasek vmasek deleted the runner-config-and-output branch February 11, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin runner config and output path gets overridden in parallel mode
2 participants