-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(test-setup): add custom matchers for ui logger #923
Conversation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit c440d62 with source commit 1686dda. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 4 audits improved, 👎 6 audits regressed, 10 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
576 other audits are unchanged. |
packages/cli/src/lib/implementation/filter.middleware.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
60d7b79
to
7363d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice testing helper!
An idea I had was also providing additional matcher for severity:
toHaveLoggedWarning
toHaveNthLoggedWarning
- ...
This might exceed the scope of this PR so consider it as am idea.
I approved the PR.
Closes #552
This PR adds custom matchers for
ui()
logger.