-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-coverage): merge multiple results for a file #688
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1eecaae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 78ea50b with source commit 37b3283. 🏷️ Categories🗃️ Groups👍 2 groups improved, 👎 1 group regressed
18 other groups are unchanged. 🛡️ Audits👍 9 audits improved, 👎 1 audit regressed, 11 audits changed without impacting score
501 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort 👍
9b92076
to
c385da8
Compare
Closes #560
Fixes part of #647
In this PR, I implement a merging logic in order to collect coverage for the same file system from multiple test suites:
Tested on our CLI + unit tested.