Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-lighthouse): add lighthouse CI flags to configs #659

Merged
merged 10 commits into from
May 14, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Apr 29, 2024

When using Chrome it helps to have a set of flags for more stable runs in a tooling environment like thee CI.
The chrome-launcher package provides a set of flags dedicated to tooling that they also documented very well.

This PR includes:

  • docs
  • uses tooling flags in both configs

closes #657

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🧩 lighthouse-plugin 🛠️ tooling labels Apr 29, 2024
Copy link

nx-cloud bot commented Apr 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 77caed5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented Apr 29, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 38a7b20 with source commit 6f92d90.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 68 🟡 79 ↓ −10.9
Updates 🟡 70 🟡 70 ↑ +0.2
Code coverage 🟡 70 🟡 70 ↑ +0
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟡 80 🟡 80
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 68 🟡 79 ↓ −10.9
JS Packages NPM outdated dependencies 🟡 70 🟡 70 ↑ +0.2
Code coverage Code coverage metrics 🟡 70 🟡 70 ↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 3 audits improved, 👎 9 audits regressed, 7 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse JavaScript execution time 🟥 1.3 s 🟩 1.1 s ↑ +21 %
Lighthouse Total Blocking Time 🟥 1,240 ms 🟥 620 ms ↑ +100 %
Lighthouse Max Potential First Input Delay 🟥 1,070 ms 🟥 430 ms ↑ +148 %
Lighthouse First Contentful Paint 🟩 1.7 s 🟩 1.3 s ↑ +30 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.0 s ↑ +6 %
Lighthouse Time to Interactive 🟨 3.9 s 🟩 3.4 s ↑ +14 %
Lighthouse Speed Index 🟩 2.5 s 🟩 1.7 s ↑ +51 %
JS Packages Outdated NPM dev dependencies. 🟨 49 outdated package versions (24 major, 20 minor, 4 patch, 1 prerelease) 🟨 48 outdated package versions (24 major, 20 minor, 3 patch, 1 prerelease) ↑ +2 %
Lighthouse First Meaningful Paint 🟩 1.7 s 🟩 1.4 s ↑ +24 %
Code coverage Function coverage 🟨 64 % 🟨 64 %  +0 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 67 % 🟨 67 %  +0 %
Lighthouse Minimizes main-thread work 🟥 4.3 s 🟥 3.2 s ↑ +31 %
Lighthouse Metrics 🟩 3866 🟩 3398 ↑ +14 %
Lighthouse Properly size images 🟥 Potential savings of 327 KiB 🟥 Potential savings of 327 KiB ↓ −17 %
Lighthouse Server Backend Latencies 🟩 30 ms 🟩 20 ms ↑ +127 %
Lighthouse Initial server response time was short 🟩 Root document took 0 ms 🟩 Root document took 10 ms ↓ −50 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↓ −33 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 467 KiB 🟩 Total size was 467 KiB ↓ +0 %

504 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review May 2, 2024 10:28
@BioPhoton BioPhoton requested a review from matejchalk as a code owner May 2, 2024 10:28
code-pushup.config.ts Show resolved Hide resolved
packages/plugin-lighthouse/README.md Outdated Show resolved Hide resolved
packages/plugin-lighthouse/README.md Outdated Show resolved Hide resolved
packages/plugin-lighthouse/README.md Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk May 3, 2024 10:28
@BioPhoton BioPhoton merged commit 590aeec into main May 14, 2024
19 checks passed
@BioPhoton BioPhoton deleted the lighthouse-ci-flags branch May 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 lighthouse-plugin 📖 Project documentation improvements or additions to the project documentation 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse tests are flaky
2 participants