-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(plugin-js-packages): use semver for version diff #656
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7f99d02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
packages/plugin-js-packages/src/lib/runner/outdated/transform.ts
Outdated
Show resolved
Hide resolved
Where? Maybe a guard helps? |
packages/plugin-js-packages/src/lib/runner/outdated/constants.ts
Outdated
Show resolved
Hide resolved
packages/plugin-js-packages/src/lib/runner/outdated/transform.ts
Outdated
Show resolved
Hide resolved
packages/plugin-js-packages/src/lib/runner/outdated/transform.ts
Outdated
Show resolved
Hide resolved
packages/plugin-js-packages/src/lib/runner/outdated/transform.ts
Outdated
Show resolved
Hide resolved
bb2e42e
to
f59200d
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 8432fb9 with source commit 6bc746b. 🏷️ Categories🗃️ Groups👍 2 groups improved, 👎 1 group regressed
18 other groups are unchanged. 🛡️ Audits👍 6 audits improved, 👎 3 audits regressed, 11 audits changed without impacting score
503 other audits are unchanged. |
f59200d
to
7f99d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, looks very robust 👍
Related to #597
In this PR, I use
semver
functions to determine the version difference.