Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-js-packages): use semver for version diff #656

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Apr 25, 2024

Related to #597

In this PR, I use semver functions to determine the version difference.

Copy link

nx-cloud bot commented Apr 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7f99d02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 js-packages-plugin Plugin for audit and outdated dependencies 🛠️ tooling labels Apr 25, 2024
@Tlacenka Tlacenka added the 🚧 blocked blocked issue label Apr 25, 2024
BioPhoton
BioPhoton previously approved these changes Apr 27, 2024
@BioPhoton
Copy link
Collaborator

Can I get rid of the non-null-assertion? I use semver functions to make sure to filter out null values and up-to-date dependencies but TS does not know.

Where? Maybe a guard helps?

Copy link

github-actions bot commented Apr 30, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 8432fb9 with source commit 6bc746b.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Security 🟢 100 🟡 80 ↑ +20
Performance 🟡 87 🟡 77 ↑ +9.6
Code coverage 🟡 68 🟡 68 ↓ +0
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Updates 🟡 70 🟡 70
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
JS Packages NPM audit 🟢 100 🟡 80 ↑ +20
Lighthouse Performance 🟡 87 🟡 77 ↑ +9.6
Code coverage Code coverage metrics 🟡 68 🟡 68 ↓ +0

18 other groups are unchanged.

🛡️ Audits

👍 6 audits improved, 👎 3 audits regressed, 11 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse JavaScript execution time 🟩 0.9 s 🟥 1.3 s ↓ −29 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟩 0 vulnerabilities 🟥 23 vulnerabilities (23 moderate) ↓ −100 %
Lighthouse Total Blocking Time 🟨 290 ms 🟥 670 ms ↓ −56 %
Lighthouse Max Potential First Input Delay 🟥 380 ms 🟥 470 ms ↓ −20 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.1 s ↑ +3 %
Lighthouse Speed Index 🟩 2.0 s 🟩 1.6 s ↑ +27 %
Lighthouse Time to Interactive 🟩 3.1 s 🟩 3.2 s ↓ −5 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 64 % 🟨 64 %  +0 %
Lighthouse Minimizes main-thread work 🟥 3.2 s 🟥 3.8 s ↓ −18 %
Lighthouse Properly size images 🟥 Potential savings of 327 KiB 🟥 Potential savings of 327 KiB ↑ +12 %
Lighthouse Metrics 🟩 3093 🟩 3239 ↓ −5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 467 KiB 🟩 Total size was 467 KiB ↓ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 14 resources found 🟨 14 resources found ↓ +0 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 20 ms ↓ −60 %
Lighthouse First Contentful Paint 🟩 1.3 s 🟩 1.3 s ↑ +0 %
Lighthouse First Meaningful Paint 🟩 1.3 s 🟩 1.3 s ↑ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 10 ms 🟩 Root document took 0 ms ↑ +100 %
Lighthouse Server Backend Latencies 🟩 20 ms 🟩 20 ms ↓ −12 %
JS Packages Outdated NPM dev dependencies. 🟥 49 outdated package versions (25 major, 19 minor, 4 patch, 1 prerelease) 🟥 48 outdated package versions (25 major, 19 minor, 4 patch) ↑ +2 %

503 other audits are unchanged.

@Tlacenka Tlacenka force-pushed the js-packages/semver branch from f59200d to 7f99d02 Compare April 30, 2024 08:30
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, looks very robust 👍

@Tlacenka Tlacenka merged commit 31d2301 into main Apr 30, 2024
19 checks passed
@Tlacenka Tlacenka deleted the js-packages/semver branch April 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 js-packages-plugin Plugin for audit and outdated dependencies 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants