-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-lighthouse): add chromium to dev deps #654
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c264e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit db87192 with source commit f11f8a7. 🏷️ Categories🗃️ Groups👍 2 groups improved, 👎 1 group regressed
18 other groups are unchanged. 🛡️ Audits👍 2 audits improved, 👎 11 audits regressed, 10 audits changed without impacting score
500 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the name of all the people not using Chrome, thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅Did a check on fresh windows installation without Chrome.
On main
branch it complains about no path to Chrome.exe,
on this branch all integration tests pass and chromium
path is autodetected as a local path \node_modules\chromium\lib\chromium\chrome-win\chrome.exe
This PR adds
chromium
as NPM dependency to the repository. This should enable a development setup that works afternpm ci
out of the box. Potential further steps are adding chrome toplugin-lighthosue
too.This PR includes:
chromium
Note
Our testing setup snippet uses
getChromePath
which internally does not check forchromium
, so I added a fallback.See:
testing/test-setup/src/lib/chrome-path.setup.ts
How to test it for contributors that did not have Chrome installed?
On your local machine:
CHROME_PATH
in the env variables (optional)npm ci
How to test it for contributors that had Chrome installed but autodetecting the path failed?
On your local machine:
CHROME_PATH
in the env variables (optional)npm remove chromium
closes #650