Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): add better error messages #641

Merged
merged 7 commits into from
May 2, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Apr 23, 2024

Before:
Screenshot 2024-04-23 at 17 23 49

After:
Screenshot 2024-04-23 at 17 22 47

closes #640

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 core labels Apr 23, 2024
@BioPhoton BioPhoton marked this pull request as ready for review April 23, 2024 22:26
@BioPhoton BioPhoton requested a review from Tlacenka as a code owner April 23, 2024 22:26
Copy link

github-actions bot commented Apr 25, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 697fb1b with source commit 6f92d90.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 78 🟡 79 ↓ −0.5
Code coverage 🟡 70 🟡 70 ↑ +0
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟡 80 🟡 80
Updates 🟡 70 🟡 70
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 1 group improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 78 🟡 79 ↓ −0.5
Code coverage Code coverage metrics 🟡 70 🟡 70 ↑ +0

19 other groups are unchanged.

🛡️ Audits

👍 6 audits improved, 👎 3 audits regressed, 11 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Largest Contentful Paint element 🟩 2,170 ms 🟥 2,970 ms  −∞ %
Lighthouse Largest Contentful Paint 🟩 2.2 s 🟨 3.0 s ↓ −27 %
Lighthouse Total Blocking Time 🟥 860 ms 🟥 620 ms ↑ +39 %
Lighthouse Max Potential First Input Delay 🟥 680 ms 🟥 430 ms ↑ +59 %
Lighthouse Time to Interactive 🟩 2.9 s 🟩 3.4 s ↓ −13 %
Lighthouse First Meaningful Paint 🟩 1.3 s 🟩 1.4 s ↓ −5 %
Code coverage Function coverage 🟨 64 % 🟨 64 %  +0 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 67 % 🟨 67 %  +0 %
Lighthouse Minimizes main-thread work 🟥 4.1 s 🟥 3.2 s ↑ +28 %
Lighthouse Properly size images 🟥 Potential savings of 327 KiB 🟥 Potential savings of 327 KiB ↓ −41 %
Lighthouse Metrics 🟩 2946 🟩 3398 ↓ −13 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 467 KiB 🟩 Total size was 467 KiB ↑ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 14 resources found 🟨 14 resources found ↑ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 120 ms 🟩 Root document took 10 ms ↑ +1883 %
Lighthouse Speed Index 🟩 1.6 s 🟩 1.7 s ↓ −3 %
Lighthouse First Contentful Paint 🟩 1.3 s 🟩 1.3 s ↓ −1 %
Lighthouse Server Backend Latencies 🟩 20 ms 🟩 20 ms ↑ +40 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↑ +56 %
Lighthouse JavaScript execution time 🟩 1.1 s 🟩 1.1 s ↓ +0 %

503 other audits are unchanged.

@BioPhoton BioPhoton requested a review from matejchalk April 25, 2024 10:18
@BioPhoton BioPhoton removed the request for review from Tlacenka May 2, 2024 10:18
@BioPhoton BioPhoton merged commit 7b2834c into main May 2, 2024
19 checks passed
@BioPhoton BioPhoton deleted the add-better-error-messages-to-core branch May 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 core 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better plugin execution errors
2 participants