Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 5, 2025

Precondition:

This PR includes:

  • allows us to execute the repositories code of:
    • cli project'
    • nx-plugin projects executors (not the target inference)
  • removes pluginBin option as it would only help product development and is not working with dependent bundles
  • more intuitive naming

Note

After this is merged is should be possible to use it locally like this:

_nx.json.defaultTargets

"code-pushup": {
      "dependsOn": ["cli:build", "nx-plugin:build"],
      "executor": "@copde-pushup/nx-plugin:cli",
      "options": {
        "bin": "./packages/cli/dist",
        "env": {
          "NODE_OPTIONS": "--import tsx",
          "TSX_TSCONFIG_PATH": "tsconfig.base.json"
        }
    }
}

or

nx.json.plugins

{
      "plugin": "@code-pushup/nx-plugin",
      "options": {
        "bin": "./packages/cli/dist",
        "env": {
          "NODE_OPTIONS": "--import tsx",
          "TSX_TSCONFIG_PATH": "tsconfig.base.json"
        }
    }
}

Then run: nx code-pushup

You will see a log that prints the executed command as copy past version for you to re-ensure the setup.
NODE_OPTIONS="--import tsx" TSX_TSCONFIG_PATH="tsconfig.base.json" npx @code-pushup/cli --verbose --no-progress --config="code-pushup.config.ts" --upload.project="cli-workspace"

The only thing that is left but blocked by Nx, is using the local target inference code with external dependencies.

Another precondition of:

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Sep 5, 2025
Copy link

nx-cloud bot commented Sep 5, 2025

View your CI Pipeline Execution ↗ for commit dc2fbf9

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 54s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 55s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-04 15:25:56 UTC

Copy link

nx-cloud bot commented Sep 5, 2025

View your CI Pipeline Execution ↗ for commit 695acbc


☁️ Nx Cloud last updated this comment at 2025-09-05 17:32:01 UTC

Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1109

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1109

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1109

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1109

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1109

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1109

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1109

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1109

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1109

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1109

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1109

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1109

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1109

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1109

commit: dc2fbf9

Copy link
Contributor

github-actions bot commented Sep 5, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 5f8d397 with previous commit 33714e2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 34 ↓ −1.3
Updates 🟡 84 🟡 84 ↓ −0.2
Code coverage 🟡 90 🟡 90 ↑ +0.1
Security 🟡 56 🟡 56
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 24 🔴 24
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 34 ↓ −1.3
JS Packages NPM outdated dependencies 🟡 84 🟡 84 ↓ −0.2
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Total Blocking Time 🟥 1,640 ms 🟥 2,450 ms ↑ +50 %
Lighthouse Speed Index 🟥 7.2 s 🟥 6.7 s ↓ −6.2 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.2 s ↓ −2.2 %
JS Packages Outdated NPM dev dependencies. 🟨 59 outdated package versions (27 major, 24 minor, 8 patch) 🟨 59 outdated package versions (28 major, 23 minor, 8 patch)  +0 %
Code coverage Branch coverage 🟨 85.5 % 🟨 85.5 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 11.9 s 🟥 14.0 s ↑ +18 %
Lighthouse JavaScript execution time 🟥 5.0 s 🟥 6.0 s ↑ +19.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Largest Contentful Paint 🟥 11.3 s 🟥 11.8 s ↑ +4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,039 KiB 🟩 Total size was 2,039 KiB ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 1,540 ms 🟩 1,180 ms ↓ −23.3 %
Lighthouse Max Potential First Input Delay 🟥 1,390 ms 🟥 1,610 ms ↑ +15.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 102 KiB ↑ +37 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 78 KiB 🟥 Potential savings of 103 KiB ↑ +56.7 %
Lighthouse Initial server response time was short 🟩 Root document took 600 ms 🟩 Root document took 450 ms ↓ −24.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.4 %
Lighthouse Time to Interactive 🟥 13.6 s 🟥 13.6 s ↓ −0.4 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 179 KiB 🟥 Potential savings of 180 KiB ↑ +3.3 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 50 ms ↑ +12.4 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 11 vulnerabilities (1 critical, 5 moderate, 5 low) 🟥 15 vulnerabilities (1 critical, 5 moderate, 9 low) ↑ +36.4 %
Code coverage Line coverage 🟨 86.3 % 🟨 86.3 % ↓ −0.1 %

589 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 5, 2025 17:29
@BioPhoton BioPhoton requested a review from matejchalk September 5, 2025 17:38
@github-actions github-actions bot removed the 📖 Project documentation improvements or additions to the project documentation label Sep 9, 2025
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants