Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 25, 2025

Precondition:

This PR includes:

  • nx migrate latest
  • run migrations
  • small fixes for new Nx version in helpers
  • due to version updates typescript and eslint tests changes. same for lighthouse e2e tests
migrations.json ```json { "migrations": [ { "version": "20.0.0-beta.7", "description": "Migration for v20.0.0-beta.7", "implementation": "./src/migrations/update-20-0-0/move-use-daemon-process", "package": "nx", "name": "move-use-daemon-process" }, { "version": "20.0.1", "description": "Set `useLegacyCache` to true for migrating workspaces", "implementation": "./src/migrations/update-20-0-1/use-legacy-cache", "x-repair-skip": true, "package": "nx", "name": "use-legacy-cache" }, { "version": "21.0.0-beta.8", "description": "Removes the legacy cache configuration from nx.json", "implementation": "./src/migrations/update-21-0-0/remove-legacy-cache", "package": "nx", "name": "remove-legacy-cache" }, { "version": "21.0.0-beta.8", "description": "Removes the legacy cache configuration from nx.json", "implementation": "./src/migrations/update-21-0-0/remove-custom-tasks-runner", "package": "nx", "name": "remove-custom-tasks-runner" }, { "version": "21.0.0-beta.11", "description": "Updates release version config based on the breaking changes in Nx v21", "implementation": "./src/migrations/update-21-0-0/release-version-config-changes", "package": "nx", "name": "release-version-config-changes" }, { "version": "21.0.0-beta.11", "description": "Updates release changelog config based on the breaking changes in Nx v21", "implementation": "./src/migrations/update-21-0-0/release-changelog-config-changes", "package": "nx", "name": "release-changelog-config-changes" }, { "version": "21.1.0-beta.2", "description": "Adds **/nx-rules.mdc and **/nx.instructions.md to .gitignore if not present", "implementation": "./src/migrations/update-21-1-0/add-gitignore-entry", "package": "nx", "name": "21-1-0-add-ignore-entries-for-nx-rule-files" }, { "version": "20.0.4-beta.0", "description": "Add gitignore entry for temporary vite config files.", "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-0-4" }, { "version": "20.0.6-beta.0", "description": "Add gitignore entry for temporary vite config files and remove previous incorrect glob.", "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-0-6" }, { "version": "20.3.0-beta.2", "description": "Add gitignore entry for temporary vitest config files.", "implementation": "./src/migrations/update-20-3-0/add-vitest-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-3-0" }, { "version": "20.5.0-beta.2", "description": "Install jiti as a devDependency to allow vite to parse TS postcss files.", "implementation": "./src/migrations/update-20-5-0/install-jiti", "package": "@nx/vite", "name": "update-20-5-0-install-jiti" }, { "version": "20.5.0-beta.3", "description": "Update resolve.conditions to include defaults that are no longer provided by Vite.", "implementation": "./src/migrations/update-20-5-0/update-resolve-conditions", "package": "@nx/vite", "name": "update-20-5-0-update-resolve-conditions" }, { "version": "20.5.0-beta.3", "description": "Add vite config temporary files to the ESLint configuration ignore patterns if ESLint is used.", "implementation": "./src/migrations/update-20-5-0/eslint-ignore-vite-temp-files", "package": "@nx/vite", "name": "eslint-ignore-vite-temp-files" }, { "cli": "nx", "version": "20.2.0-beta.2", "description": "Update the ModuleFederationConfig import use @nx/module-federation.", "factory": "./src/migrations/update-20-2-0/migrate-mf-imports-to-new-package", "package": "@nx/react", "name": "update-20-2-0-update-module-federation-config-import" }, { "cli": "nx", "version": "20.2.0-beta.2", "description": "Update the withModuleFederation import use @nx/module-federation/webpack.", "factory": "./src/migrations/update-20-2-0/migrate-with-mf-import-to-new-package", "package": "@nx/react", "name": "update-20-2-0-update-with-module-federation-import" }, { "cli": "nx", "version": "20.3.0-beta.2", "description": "If workspace includes Module Federation projects, ensure the new @nx/module-federation package is installed.", "factory": "./src/migrations/update-20-3-0/ensure-nx-module-federation-package", "package": "@nx/react", "name": "ensure-nx-module-federation-package" }, { "cli": "nx", "version": "20.4.0-beta.0", "description": "Add NX_MF_DEV_REMOTES to inputs for task hashing when '@nx/webpack:webpack' or '@nx/rspack:rspack' is used for Module Federation.", "factory": "./src/migrations/update-18-0-0/add-mf-env-var-to-target-defaults", "package": "@nx/react", "name": "add-mf-env-var-to-target-defaults" }, { "cli": "nx", "version": "21.0.0-beta.11", "description": "Replaces `classProperties.loose` option with `loose`.", "factory": "./src/migrations/update-21-0-0/update-babel-loose", "package": "@nx/react", "name": "update-21-0-0-update-babel-loose" } ] }

</details>

Copy link

nx-cloud bot commented Aug 25, 2025

View your CI Pipeline Execution ↗ for commit 3ed3903

Command Status Duration Result
nx code-pushup -- compare --verbose ✅ Succeeded 7s View ↗
nx code-pushup -- --verbose ✅ Succeeded 5m 7s View ↗
nx code-pushup -- print-config --verbose --outp... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-26 22:52:28 UTC

Copy link

pkg-pr-new bot commented Aug 25, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1082

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1082

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1082

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1082

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1082

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1082

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1082

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1082

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1082

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1082

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1082

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1082

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1082

commit: 3ed3903

Copy link

github-actions bot commented Aug 25, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit e8944b6 with previous commit 56f1c4c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🔴 0 🟡 64 ↑ +64
Updates 🟡 77 🟡 85 ↑ +8.8
Performance 🔴 32 🔴 33 ↑ +1.3
Code coverage 🟢 91 🟢 90 ↓ −0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 3 groups improved, 👎 2 groups regressed, 👍 6 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🔴 0 🟡 64 ↑ +64
JS Packages NPM outdated dependencies 🟡 77 🟡 85 ↑ +8.8
Lighthouse Performance 🔴 32 🔴 33 ↑ +1.3
Code coverage Code coverage metrics 🟢 91 🟢 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Vulnerabilities for NPM prod dependencies. 🟥 10 vulnerabilities (1 critical, 2 high, 7 low) 🟨 8 vulnerabilities (1 high, 7 low) ↓ −20 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,665 KiB 🟨 Total size was 2,677 KiB ↑ +0.5 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (30 major, 21 minor, 6 patch) 🟨 51 outdated package versions (21 major, 25 minor, 5 patch) ↓ −10.5 %
JS Packages Outdated NPM prod dependencies. 🟨 17 outdated package versions (5 major, 7 minor, 5 patch) 🟨 16 outdated package versions (3 major, 8 minor, 5 patch) ↓ −5.9 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.1 s ↓ −4.5 %
Lighthouse Speed Index 🟥 7.5 s 🟥 7.3 s ↓ −2.3 %
Lighthouse Total Blocking Time 🟥 3,780 ms 🟥 2,850 ms ↓ −24.8 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.5 % ↓ −0.1 %
Code coverage Function coverage 🟩 93.2 % 🟩 93.1 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 227 undocumented variables 🟥 229 undocumented variables ↑ +0.9 %
Lighthouse Minimizes main-thread work 🟥 13.0 s 🟥 11.2 s ↓ −13.9 %
Lighthouse JavaScript execution time 🟥 5.6 s 🟥 4.7 s ↓ −16.5 %
Lighthouse Largest Contentful Paint 🟥 11.3 s 🟥 12.3 s ↑ +8.1 %
Lighthouse Max Potential First Input Delay 🟥 1,020 ms 🟥 1,690 ms ↑ +66.6 %
Lighthouse Server Backend Latencies 🟩 1,540 ms 🟩 2,040 ms ↑ +32.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2 %
Lighthouse Time to Interactive 🟥 17.3 s 🟥 17.6 s ↑ +2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 91 KiB 🟥 Potential savings of 91 KiB ↓ −30.4 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 613 KiB 🟥 Potential savings of 582 KiB ↑ +5.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 116 KiB 🟥 Potential savings of 113 KiB ↑ +4.9 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 35 vulnerabilities (8 critical, 9 high, 9 moderate, 9 low) 🟥 12 vulnerabilities (1 critical, 6 moderate, 5 low) ↓ −65.7 %
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟩 Root document took 450 ms ↓ −1.2 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 40 ms ↑ +3.3 %

586 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 25, 2025 02:38
@BioPhoton BioPhoton requested a review from matejchalk as a code owner August 25, 2025 02:38
@BioPhoton BioPhoton changed the title test: update Nx to 21 chore: update Nx to 21 Aug 25, 2025
@BioPhoton BioPhoton changed the title chore: update Nx to 21 chore: update Nx to v21 Aug 25, 2025
@BioPhoton BioPhoton requested a review from matejchalk August 25, 2025 16:11
matejchalk
matejchalk previously approved these changes Aug 25, 2025
matejchalk
matejchalk previously approved these changes Aug 25, 2025
@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Aug 25, 2025
@BioPhoton BioPhoton force-pushed the test/cleanup-e2e-test branch from e5f2bf4 to 7d435f4 Compare August 25, 2025 17:04
@github-actions github-actions bot removed the 🦾 CI/CD Continuous integration and deployment label Aug 25, 2025
@BioPhoton BioPhoton requested a review from matejchalk August 25, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants