-
Notifications
You must be signed in to change notification settings - Fork 16
chore: update Nx to v21 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BioPhoton
wants to merge
25
commits into
main
Choose a base branch
from
test/cleanup-e2e-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: update Nx to v21 #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 3ed3903
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit e8944b6 with previous commit 56f1c4c. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👎 2 groups regressed, 👍 6 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
586 other audits are unchanged. |
matejchalk
reviewed
Aug 25, 2025
packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/cli/project.json
Outdated
Show resolved
Hide resolved
packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/core/project.json
Outdated
Show resolved
Hide resolved
packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/nx-plugin/project.json
Outdated
Show resolved
Hide resolved
# Conflicts: # nx.json
…plugin/project.json Co-authored-by: Matěj Chalk <[email protected]>
…e/project.json Co-authored-by: Matěj Chalk <[email protected]>
…/project.json Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
reviewed
Aug 25, 2025
# Conflicts: # packages/nx-plugin/package.json
matejchalk
previously approved these changes
Aug 25, 2025
matejchalk
previously approved these changes
Aug 25, 2025
e5f2bf4
to
7d435f4
Compare
matejchalk
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 coverage-plugin
🧩 lighthouse-plugin
🧩 nx-plugin
🔬 testing
writing tests
🛠️ tooling
🧩 typescript-plugin
TypeScript plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precondition:
This PR includes:
migrations.json
```json { "migrations": [ { "version": "20.0.0-beta.7", "description": "Migration for v20.0.0-beta.7", "implementation": "./src/migrations/update-20-0-0/move-use-daemon-process", "package": "nx", "name": "move-use-daemon-process" }, { "version": "20.0.1", "description": "Set `useLegacyCache` to true for migrating workspaces", "implementation": "./src/migrations/update-20-0-1/use-legacy-cache", "x-repair-skip": true, "package": "nx", "name": "use-legacy-cache" }, { "version": "21.0.0-beta.8", "description": "Removes the legacy cache configuration from nx.json", "implementation": "./src/migrations/update-21-0-0/remove-legacy-cache", "package": "nx", "name": "remove-legacy-cache" }, { "version": "21.0.0-beta.8", "description": "Removes the legacy cache configuration from nx.json", "implementation": "./src/migrations/update-21-0-0/remove-custom-tasks-runner", "package": "nx", "name": "remove-custom-tasks-runner" }, { "version": "21.0.0-beta.11", "description": "Updates release version config based on the breaking changes in Nx v21", "implementation": "./src/migrations/update-21-0-0/release-version-config-changes", "package": "nx", "name": "release-version-config-changes" }, { "version": "21.0.0-beta.11", "description": "Updates release changelog config based on the breaking changes in Nx v21", "implementation": "./src/migrations/update-21-0-0/release-changelog-config-changes", "package": "nx", "name": "release-changelog-config-changes" }, { "version": "21.1.0-beta.2", "description": "Adds **/nx-rules.mdc and **/nx.instructions.md to .gitignore if not present", "implementation": "./src/migrations/update-21-1-0/add-gitignore-entry", "package": "nx", "name": "21-1-0-add-ignore-entries-for-nx-rule-files" }, { "version": "20.0.4-beta.0", "description": "Add gitignore entry for temporary vite config files.", "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-0-4" }, { "version": "20.0.6-beta.0", "description": "Add gitignore entry for temporary vite config files and remove previous incorrect glob.", "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-0-6" }, { "version": "20.3.0-beta.2", "description": "Add gitignore entry for temporary vitest config files.", "implementation": "./src/migrations/update-20-3-0/add-vitest-temp-files-to-git-ignore", "package": "@nx/vite", "name": "update-20-3-0" }, { "version": "20.5.0-beta.2", "description": "Install jiti as a devDependency to allow vite to parse TS postcss files.", "implementation": "./src/migrations/update-20-5-0/install-jiti", "package": "@nx/vite", "name": "update-20-5-0-install-jiti" }, { "version": "20.5.0-beta.3", "description": "Update resolve.conditions to include defaults that are no longer provided by Vite.", "implementation": "./src/migrations/update-20-5-0/update-resolve-conditions", "package": "@nx/vite", "name": "update-20-5-0-update-resolve-conditions" }, { "version": "20.5.0-beta.3", "description": "Add vite config temporary files to the ESLint configuration ignore patterns if ESLint is used.", "implementation": "./src/migrations/update-20-5-0/eslint-ignore-vite-temp-files", "package": "@nx/vite", "name": "eslint-ignore-vite-temp-files" }, { "cli": "nx", "version": "20.2.0-beta.2", "description": "Update the ModuleFederationConfig import use @nx/module-federation.", "factory": "./src/migrations/update-20-2-0/migrate-mf-imports-to-new-package", "package": "@nx/react", "name": "update-20-2-0-update-module-federation-config-import" }, { "cli": "nx", "version": "20.2.0-beta.2", "description": "Update the withModuleFederation import use @nx/module-federation/webpack.", "factory": "./src/migrations/update-20-2-0/migrate-with-mf-import-to-new-package", "package": "@nx/react", "name": "update-20-2-0-update-with-module-federation-import" }, { "cli": "nx", "version": "20.3.0-beta.2", "description": "If workspace includes Module Federation projects, ensure the new @nx/module-federation package is installed.", "factory": "./src/migrations/update-20-3-0/ensure-nx-module-federation-package", "package": "@nx/react", "name": "ensure-nx-module-federation-package" }, { "cli": "nx", "version": "20.4.0-beta.0", "description": "Add NX_MF_DEV_REMOTES to inputs for task hashing when '@nx/webpack:webpack' or '@nx/rspack:rspack' is used for Module Federation.", "factory": "./src/migrations/update-18-0-0/add-mf-env-var-to-target-defaults", "package": "@nx/react", "name": "add-mf-env-var-to-target-defaults" }, { "cli": "nx", "version": "21.0.0-beta.11", "description": "Replaces `classProperties.loose` option with `loose`.", "factory": "./src/migrations/update-21-0-0/update-babel-loose", "package": "@nx/react", "name": "update-21-0-0-update-babel-loose" } ] }