Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 21, 2025

This PR includes:

  • add loadArtifacts helper and tests
  • add preperation logic
  • adjust models exports
  • adjust aritfacts schemas for glob patterns

Related to:

Copy link

pkg-pr-new bot commented Aug 21, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1077

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1077

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1077

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1077

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1077

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1077

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1077

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1077

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1077

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1077

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1077

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1077

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1077

commit: 4fa733a

Copy link

github-actions bot commented Aug 21, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 78501b1 with previous commit 56f1c4c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 41 ↑ +8.7
Code coverage 🟢 91 🟢 91 ↑ +0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 8 audits improved, 👎 3 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 41 ↑ +8.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,665 KiB 🟨 Total size was 2,668 KiB ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 613 KiB 🟨 Potential savings of 582 KiB ↓ −100 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 91 KiB 🟨 Potential savings of 100 KiB ↓ −100 %
Lighthouse Largest Contentful Paint 🟥 11.3 s 🟥 4.6 s ↓ −59.2 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.2 s ↓ −3.9 %
Lighthouse Speed Index 🟥 7.5 s 🟥 7.4 s ↓ −0.8 %
Lighthouse Total Blocking Time 🟥 3,780 ms 🟥 4,720 ms ↑ +24.7 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.4 % ↑ +0.1 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.7 % ↑ +0.1 %
JSDoc coverage Functions coverage 🟥 517 undocumented functions 🟥 519 undocumented functions ↑ +0.4 %
Code coverage Function coverage 🟩 93.2 % 🟩 93.2 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 13.0 s 🟥 16.4 s ↑ +26.3 %
Lighthouse JavaScript execution time 🟥 5.6 s 🟥 6.5 s ↑ +14.6 %
Lighthouse Max Potential First Input Delay 🟥 1,020 ms 🟥 1,530 ms ↑ +50.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.6 %
Lighthouse Time to Interactive 🟥 17.3 s 🟥 17.7 s ↑ +2.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 1,540 ms 🟩 1,380 ms ↓ −10.5 %
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟩 Root document took 330 ms ↓ −26.7 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 10 ms ↓ −67.5 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

589 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 22, 2025 03:09
@BioPhoton BioPhoton requested a review from matejchalk as a code owner August 22, 2025 03:09
@BioPhoton BioPhoton requested a review from matejchalk August 22, 2025 14:39
Copy link

nx-cloud bot commented Aug 22, 2025

View your CI Pipeline Execution ↗ for commit 4fa733a

Command Status Duration Result
nx code-pushup -- compare --verbose ✅ Succeeded 8s View ↗
nx code-pushup -- --verbose ✅ Succeeded 4m 30s View ↗
nx code-pushup -- print-config --verbose --outp... ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-26 22:56:43 UTC

matejchalk
matejchalk previously approved these changes Aug 25, 2025
…d-artifact-loading-logic

# Conflicts:
#	packages/models/src/index.ts
matejchalk
matejchalk previously approved these changes Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants