Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin runner config and output path gets overridden in parallel mode #930

Closed
vmasek opened this issue Feb 3, 2025 · 0 comments · Fixed by #929
Closed

Plugin runner config and output path gets overridden in parallel mode #930

vmasek opened this issue Feb 3, 2025 · 0 comments · Fixed by #929
Assignees
Labels
🐛 bug something isn't working

Comments

@vmasek
Copy link
Collaborator

vmasek commented Feb 3, 2025

What happened?

When running plugins in parallel or running same plugin multiple times for different audits it overrides its runner config as the folder for each individual runner config is node_modules/.code-pushup/<plugin-name>.

What would you expect to happen?

Each runner of individual plugins should have its own unique folder to hold the config file and output file.
This can be achieved by adding one more level of nesting into runners folder as in node_modules/.code-pushup/<timestamp>/<plugin-slug>.

Also plugin slug should be used instead of hardcoded plugin name as it will be more versatile if people would reuse or extend existing plugins with their own variety (for example duplicating coverage plugin execution to get two reported coverages, one from Jest and one from Cypress component tests)

What steps did you take?

  1. Setup Code PushUp target with ESLint for multiple projects in one Nx monorepo
  2. For better reproduction have different lint rules setup in the projects
  3. Run plugins in parallel or via affected
  4. Observe errors of rules not being found or other weird behavior related to overridden runner config

Code PushUp package version

latest

What operation system are you on?

Windows

Node version

22

Relevant log output

@vmasek vmasek added the 🐛 bug something isn't working label Feb 3, 2025
@vmasek vmasek self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant