refactor(utils): tweak lint range formatting

code-pushup · Oct 1, 2024 · 690db7f · 690db7f
1 parent 6f42d61
commit 690db7f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/packages/utils/src/lib/reports/formatting.ts b/packages/utils/src/lib/reports/formatting.ts
@@ -96,10 +96,8 @@ export function formatSourceLine(
     return '';
   }
   const { startLine, endLine } = position;
-  return endLine
-    ? startLine === endLine
-      ? `${startLine}`
-      : `${startLine}-${endLine}`
+  return endLine && startLine !== endLine
+    ? `${startLine}-${endLine}`
     : `${startLine}`;
 }
 
@@ -112,14 +110,13 @@ export function formatGitHubLink(
     return `${baseUrl}/${file}`;
   }
   const { startLine, endLine, startColumn, endColumn } = position;
-
   const start = startColumn ? `L${startLine}C${startColumn}` : `L${startLine}`;
   const end = endLine
     ? endColumn
       ? `L${endLine}C${endColumn}`
       : `L${endLine}`
     : '';
-  const lineRange = end ? (start === end ? start : `${start}-${end}`) : start;
+  const lineRange = end && start !== end ? `${start}-${end}` : start;
   return `${baseUrl}/${file}#${lineRange}`;
 }