Fix typehint resolution - stop prefixing unions with namespace #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@williamdes Have you had a chance to look at this? |
Contributor
Author
|
@williamdes Any update on this? |
Member
|
Hi |
williamdes
reviewed
Nov 18, 2025
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
Thank you !
I trust your work, even if there is no unit tests.
Let's see how it goes
Contributor
Author
|
Fingers crossed I didn't miss anything 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
The
typeToArray()implementation is based heavily ontypeToString(), but uses the[$type, false]array style thatresolveHint()is expecting.I'm not sure how to go about writing a test for this - I didn't have enough time to get familiar with the way your tests are written. Can you please give me some guidance? It doesn't look like the existing tests include namespaces in a way that would surface this bug and I'm not sure how to add that.