K5 guides curriculum-specified updates #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Jul 12, 2024
Comment on lines
+67
to
+79
| ...encourageStopTrainingCountsDefault.map(count => { | ||
| return { | ||
| id: `fishvtrash-training-generic-please-continue-count-${count}`, | ||
| textFn: () => I18n.t('training-generic-please-continue'), | ||
| when: { | ||
| appMode: AppMode.FishVTrash, | ||
| currentMode: Modes.Training, | ||
| fn: state => { | ||
| return state.yesCount + state.noCount >= count; | ||
| } | ||
| } | ||
| } | ||
| }), |
breville
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes to the "guides" presented in the new K5 version of this progression, which are generally:
The details of the changes requested are in this doc. Note that the
FishShortapp mode (which is used on this level in the Hour of Code script) is not used in the current K5 AI unit, so no changes are made there.Testing story
I ran through each of the affected levels and compared the guides I saw to the expected behavior on the doc linked above.
Follow-up work
We'll need to hook this up to level config such that the right version of the guides file (
guidesK5) is used in the K5 AI unit.