Add user filter by first, last, username #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a good minimal first step. But I want to see what progress @paulsullivanjr can make in wrapping up #658 and we will need to circle back to recover this to index a combination of first name/last name and username, then add some fuzzy matching of the strings (like with the skill typeahead) on the user's list items on the front-end side. Do we want to open some follow-up issues in both the API and Ember? |
|
Not sure of any other follow-ups needed, but I've created #700 |
begedin
force-pushed
the
add-user-filter
branch
from
c99a361 to
04e4999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds the ability to do basic filtering on the user endpoint. The query filters by first name, last name or username and limits to 5 results. I have little to no experience with elastic search so this felt like a preferable first step, with the intention of pushing it out as quickly as possible.