Include tasks in task_list view #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Nov 2, 2017
| @@ -28,7 +28,7 @@ defmodule CodeCorpsWeb.TaskListController do | |||
| end | |||
| end | |||
|
|
|||
| @preloads [:tasks] | |||
| @preloads [{:tasks, [:comments, :github_pull_request, :task_skills, :user_task]}] | |||
There was a problem hiding this comment.
This is using nested preloads. I am not sure if we should just add the whole list of task preloads or not. Was just adding them based on the feedback from the tests. @begedin thoughts?
There was a problem hiding this comment.
ah these are the ones marked with identifier: always
There was a problem hiding this comment.
@joshsmith would you also include the task's relationships?
There was a problem hiding this comment.
The real answer here is that it doesn't much matter what I think, but what the performance implications are. Testing this out in the browser with Scout running and doing more precise benchmarking will combined yield a better answer.
|
Closing this in favor of #1187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
includekey to tasks for the task_list viewReferences
Fixes #
Progress on: #