fix: speed up assigning many custom points at once

do not sync those points with Intra right away, let the synchronization tool handle it
codam-coding-college · Dec 27, 2024 · a9e1a76 · a9e1a76
1 parent 18be659
commit a9e1a76
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/handlers/points.ts b/src/handlers/points.ts
@@ -17,7 +17,7 @@ const INCLUDE_IN_SCORE_RETURN_DATA = {
 	},
 };
 
-export const createScore = async function(prisma: PrismaClient, type: CodamCoalitionFixedType | null, typeIntraId: number | null, userId: number, points: number, reason: string, scoreDate: Date = new Date()): Promise<CodamCoalitionScore | null> {
+export const createScore = async function(prisma: PrismaClient, type: CodamCoalitionFixedType | null, typeIntraId: number | null, userId: number, points: number, reason: string, scoreDate: Date = new Date(), syncWithIntra: boolean = true): Promise<CodamCoalitionScore | null> {
 	// Retrieve user details
 	const user = await prisma.intraUser.findFirst({
 		where: {
@@ -64,8 +64,10 @@ export const createScore = async function(prisma: PrismaClient, type: CodamCoali
 		},
 		include: INCLUDE_IN_SCORE_RETURN_DATA,
 	});
-	const api = await getAPIClient();
-	score.intra_score_id = await syncIntraScore(prisma, api, score, true); // Sync the score with Intra
+	if (syncWithIntra) {
+		const api = await getAPIClient();
+		score.intra_score_id = await syncIntraScore(prisma, api, score, true); // Sync the score with Intra
+	}
 	return score;
 }
 

diff --git a/src/routes/admin/points.ts b/src/routes/admin/points.ts
@@ -4,7 +4,7 @@ import fs from 'fs';
 import { fetchSingleApiPage, getAPIClient, getBlocAtDate, getOffset, getPageNav, getPageNumber } from '../../utils';
 import { ExpressIntraUser } from '../../sync/oauth';
 import { createScore, handleFixedPointScore, shiftScore } from '../../handlers/points';
-import { deleteIntraScore, syncIntraScore, syncTotalCoalitionScore } from '../../handlers/intrascores';
+import { deleteIntraScore, syncIntraScore, syncTotalCoalitionScore, syncTotalCoalitionsScores } from '../../handlers/intrascores';
 
 const SCORES_PER_PAGE = 100;
 
@@ -642,7 +642,7 @@ export const setupAdminPointsRoutes = function(app: Express, prisma: PrismaClien
 					continue;
 				}
 				console.log(`User ${sessionUser.login} is assigning ${scoreToCreate.points} custom points manually to ${user.login} with reason "${scoreToCreate.reason}"`);
-				const score = await createScore(prisma, null, null, user.id, scoreToCreate.points, scoreToCreate.reason);
+				const score = await createScore(prisma, null, null, user.id, scoreToCreate.points, scoreToCreate.reason, new Date(), false);
 				if (!score) {
 					console.warn(`Failed to create score for user ${user.login}`);
 					failedScores.push({ login: user.login, amount: scoreToCreate.points, error: 'Failed to create score' });