-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dedicated release note for dropping repository permissions for Administration on GitHub #1971
feat: Dedicated release note for dropping repository permissions for Administration on GitHub #1971
Conversation
Overall readability score: 54.2 (🔴 -0.05)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiacarpinteiro I left some suggestions, feel free to action what makes sense.
One general thought, there's no mention of who can action the change requested - admin, everyone, etc?
docs/release-notes/cloud/cloud-2023-12-DD-gh-admin-permission-not-requested.md
Outdated
Show resolved
Hide resolved
docs/release-notes/cloud/cloud-2023-12-DD-gh-admin-permission-not-requested.md
Outdated
Show resolved
Hide resolved
Thank you for the feedback, @RaquelHipolito! I updated accordingly. 👍
Good question! 🤔 |
#1971 (comment) |
looks great 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me, all my feedback is related to "present" VS "future" and what the semantics words like "deprecated".
Let me know if the comments were clear or let's sync and commit.
docs/release-notes/cloud/cloud-2024-01-DD-gh-repository-ssh-keys-deprecation.md
Outdated
Show resolved
Hide resolved
docs/release-notes/cloud/cloud-2024-01-DD-gh-repository-ssh-keys-deprecation.md
Outdated
Show resolved
Hide resolved
docs/release-notes/cloud/cloud-2024-01-DD-gh-repository-ssh-keys-deprecation.md
Outdated
Show resolved
Hide resolved
docs/release-notes/cloud/cloud-2024-01-DD-gh-repository-ssh-keys-deprecation.md
Outdated
Show resolved
Hide resolved
docs/release-notes/cloud/cloud-2024-01-DD-gh-repository-ssh-keys-deprecation.md
Outdated
Show resolved
Hide resolved
@jorgebraz @andrzej-janczak Thank you for your input. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiacarpinteiro @jorgebraz Left some comments. 🙏
Adds a dedicated release note page explaining that Codacy GitHub App no longer requests read and write repository permissions for Administration and what users need to do.
👀 Live preview
https://pluto-802-gh-access-tokens-release--docs-codacy.netlify.app/release-notes/cloud/cloud-2024-01-15-gh-repository-ssh-keys-discontinuation/
🚧 To do