Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Security monitor migration - SRM read access for all users TAROT-2397 #1965

Conversation

nicklem
Copy link
Contributor

@nicklem nicklem commented Dec 1, 2023

Update the docs:

  • SRM access is now open to all users (remove its mention in the permissions table)
  • Caveat admonition - only org admins and org managers can export items to CSV

👀 Live preview

🚧 To do

  • Review other potential access caveats with the squad

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Overall readability score: 54.29 (🔴 -0.02)

File Readability
managing-security-and-risk.md 62.26 (🔴 -3.91)
roles-and-permissions-for-organizations.md 55.41 (🟢 +0.43)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
managing-security-and-risk.md 62.26 37.6 9.4 11.4 11.6 6.72
  🔴 -3.91 🔴 -9.07 🔴 -0.37 🔴 -0.6 🔴 -0.23 🔴 -0.18
roles-and-permissions-for-organizations.md 55.41 28.13 9.52 13.6 13.69 6.39
  🟢 +0.43 🟢 +0.2 🟢 +0.13 🟢 +0 🔴 -0.06 🟢 +0.08

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.29 43.16 10.86 12.37 12.53 7.86
  🔴 -0.02 🔴 -0.05 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@nicklem nicklem self-assigned this Dec 4, 2023
@nicklem nicklem marked this pull request as ready for review December 11, 2023 15:00
@nicklem nicklem requested a review from a team as a code owner December 11, 2023 15:00
@nicklem
Copy link
Contributor Author

nicklem commented Dec 11, 2023

@claudiacarpinteiro As mentioned during our sync, in this PR:

  • I'm removing the SRM entry from the permissions table.
  • I'm adding admonitions where I mention the Export function to clarify that only admins and managers can export items.
    • Consider that this will change in the future when we can filter exported items correctly for every user, so we'll eventually remove these admonitions.

Let me know, thanks! 😄

Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicklem I left some comments for your evaluation. Open to discuss them. 🤓

@nicklem nicklem force-pushed the TAROT-2397-doc-security-monitor-migration-srm-read-access-for-all-users branch from 878fb66 to 7bfe85d Compare December 13, 2023 10:12
@nicklem nicklem added the don't merge Don't merge this pull request yet label Dec 13, 2023
@github-actions github-actions bot temporarily deployed to Netlify December 13, 2023 11:35 Inactive
Co-authored-by: Cláudia Carpinteiro <[email protected]>
@github-actions github-actions bot temporarily deployed to Netlify December 13, 2023 13:07 Inactive
@nicklem nicklem requested a review from a team December 13, 2023 13:08
@github-actions github-actions bot temporarily deployed to Netlify December 13, 2023 16:34 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 15, 2023 08:48 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 15, 2023 11:01 Inactive
@nicklem nicklem enabled auto-merge (squash) December 20, 2023 13:17
@nicklem nicklem removed the don't merge Don't merge this pull request yet label Dec 20, 2023
@github-actions github-actions bot temporarily deployed to Netlify December 20, 2023 13:18 Inactive
@nicklem nicklem merged commit 1e2e661 into master Dec 20, 2023
7 of 8 checks passed
@nicklem nicklem deleted the TAROT-2397-doc-security-monitor-migration-srm-read-access-for-all-users branch December 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants