-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved compiler error when compiling a project that uses ObjCpp #1382
Open
logan-5
wants to merge
105
commits into
cocos2d:v3.5.0
Choose a base branch
from
logan-5:objcpp
base: v3.5.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic removal of some android files
Clean up android, add triggering delegate calls during programming animations
It is possible now to create custom transitions without any objc-runtime hacks
ObjectAL is marked deprecated now by Apple. Somebody may prefer to use AVAudioSession instead of pulling the whole code for ObjectAL
CCPhysics code is an ugly monster. Also, there is still a lot of attention paid to Box2D, so no reason for including Chipmunk physics in stock cocos2d package
Temporary solution
Squashed commits: [bc26607] Getting rid of CCPackageManager_private.h This one was easy code was already in CCPackageManager.m
Header modifications for -ext
Adding CCNodeTag to -ext
Fixed CCTextField textField property always being nil on mac.
SpriteBuilder renamed to CocosBuilder
On behalf from latest TexturePacker added his code changes from website, for details on contentprotection see: https://www.codeandweb.com/texturepacker/contentprotection Original ZipUtils could not handle pvr.ccz version 2 correctly (wrong byte header), currently version 3 (pvr.ccz = pvr+zlib) works fine.
Converted tabs to spaces Added some comments
…atlases stored in the image asset folder.
…as-support CCSpriteFrameCache support for loading sprite sheets from image assets.
Compatibility with latest TexturePacker SpriteSheets Using PVR+zlib
…graphics in an atlas sprite asset.
Fixes atlas asset loading bug.
…C++ as well as Cocos2D-Objc. Also added an Objective-C++ test to cocos2d-tests; one involving a basic node hierarchy, the next involving a slightly more dicey manual visiting of a node with proper transforms, without necessarily adding it as a child of another node, using CCRenderer_Private. This patch does *not necessarily* allow you to compile cocos2d in Objective-C++ mode. It only ensures that you can use Objective-C++ in your project along with Cocos2D-Objc. The Objective-C++ fix within CCRenderer_Private.h was suggested by @slembcke here: http://forum.spritebuilder.com/t/cocos3d-c-mm-files-compiler-issue/15570/4
I think this error appears only with ObjCpp compilers.. I have to look at it more precisely a bit later. I actually use ObjC++ now in my project with 3.5 and do not face any issues, I have to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as well as Cocos2D-Objc. Also added an Objective-C++ test to cocos2d-tests; one involving a basic node hierarchy, the next involving a slightly more dicey manual visiting of a node with proper transforms, without necessarily adding it as a child of another node, using CCRenderer_Private.h.
This patch does not necessarily allow you to compile cocos2d in Objective-C++ mode. It only ensures that you can use Objective-C++ in your project along with Cocos2D-Objc.
The Objective-C++ fix within CCRenderer_Private.h was suggested by @slembcke here: http://forum.spritebuilder.com/t/cocos3d-c-mm-files-compiler-issue/15570/4