setInstancedAttribute #17858
Open
setInstancedAttribute #17858
+54
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
star-e
reviewed
Nov 14, 2024
| size_t byteLength = 0; | ||
| if (val.toObject()->getTypedArrayData(&data, &byteLength) && data != nullptr && byteLength > 0) { | ||
| cobj->setInstancedAttribute(name, reinterpret_cast<const float *>(data), static_cast<uint32_t>(byteLength)); | ||
| size_t byteCount = 0; |
There was a problem hiding this comment.
I think byteCount means elementCount？
Becasue byteCount is no different from byteLength by name.
There was a problem hiding this comment.
getTypedArrayData returns byte length of the internal buffer.
Why change the variable name from byteLength to byteCount?
✅ Package size is not changedInterface Check ReportThis pull request does not change any public interfaces ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.