feat(i18n): complete full French locale coverage for all migrated strings - #274
Open
Enemuo-debug wants to merge 1 commit into
Open
feat(i18n): complete full French locale coverage for all migrated strings#274Enemuo-debug wants to merge 1 commit into
Enemuo-debug wants to merge 1 commit into
Conversation
…ings - fill 197 missing keys in src/lib/locale/fr.json for full en/fr key parity - native-review quality pass (Sessions, Marketing terminology fixes) - sync stale public/locale/en.json and public/locale/fr.json with bundled dicts - add vitest parity suite: key parity, non-empty values, placeholder match Closes cocor-tech#262
|
@Enemuo-debug is attempting to deploy a commit to the Nzubechukwu 's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Enemuo-debug Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #262
Summary
Completes French locale coverage so
fr.jsonhas full key parity with the canonical English dictionary, plus a quality pass and a parity test to keep it green.Changes
src/lib/locale/fr.json(151 → 348 keys, exact key-set match withen.json)Séances→Sessionsfor login sessions,Commercialisation→Marketing), kept established vocabulary consistent (e.g.Contributions) and verified interpolation placeholders ({date},{pct}) are preservedpublic/locale/en.json(153 keys) andpublic/locale/fr.jsonnow mirror the bundled dictionaries served byLocaleProvidersrc/lib/locale/__tests__/parity.test.tsasserts identical en/fr key sets, non-empty string values, matching interpolation placeholders, and thatpublic/locale/*.jsonstay in sync with the bundled dictsAcceptance criteria
npx vitest run src/lib/locale/__tests__/parity.test.ts— 4/4 passing)