Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 1.11.0 tag #257

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Prep for 1.11.0 tag #257

merged 1 commit into from
Dec 10, 2024

Conversation

fantapop
Copy link
Collaborator

@fantapop fantapop commented Dec 9, 2024

Updates Makefile and Changelog for 1.11.0 tag

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

Updates Makefile and Changelog for 1.11.0 tag
@fantapop
Copy link
Collaborator Author

fantapop commented Dec 9, 2024

I'll run the Acceptance tests against this branch

@fantapop
Copy link
Collaborator Author

fantapop commented Dec 9, 2024

There was a failure with the Maintenance Window tests because I ran this before the managed-service deploy went out which added the check that the test is looking for.

=== NAME  TestAccMaintenanceWindowResource
    maintenance_window_test.go:164: Step 1/5, expected an error with pattern, no match on: Error running apply: exit status 1
        
        Error: Error setting maintenance window
        
          with cockroach_maintenance_window.teststandard,
          on terraform_plugin_test.tf line 26, in resource "cockroach_maintenance_window" "teststandard":
          26: resource "cockroach_maintenance_window" "teststandard" {
        
        upserting maintenance window for cluster
        98ea579f-d0f1-47a3-87f4-ab50c2e5edf4: upserting maintenance window for
        cluster 98ea579f-d0f1-47a3-87f4-ab50c2e5edf4: pq: insert on table
        "maintenance_windows" violates foreign key constraint
        "maintenance_windows_cluster_id_fkey" (trace ID: 4935058963696080509)

I was planning to release the provider today but it would be nice to see a green test run which would mean we have to wait until the managed-service deploy. @marksoper what do you think?

@marksoper
Copy link
Collaborator

@fantapop let's wait until the API deployment, assuming it's within 1-2 weeks

@fantapop
Copy link
Collaborator Author

fantapop commented Dec 9, 2024

There should be a release this week.

@fantapop
Copy link
Collaborator Author

The deploy went out today. I've manually run the failing test against prod and it's now passing. I'm inclined to merge this down without running the full suite again because they'll run once more after tagging.

@fantapop fantapop requested a review from rgcase December 10, 2024 18:36
@fantapop fantapop merged commit 6a0a284 into main Dec 10, 2024
4 of 5 checks passed
@fantapop fantapop deleted the prep-for-1.11.0-tag branch December 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants