Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CC-30769] remove machine_type from examples #256

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[CC-30769] remove machine_type from examples #256

merged 1 commit into from
Dec 9, 2024

Conversation

fantapop
Copy link
Collaborator

@fantapop fantapop commented Dec 9, 2024

machine_type is not recommended for usage so we remove it from the examples and replace it with num_virtual_cpus instead.

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@fantapop fantapop requested review from rgcase and kathancox December 9, 2024 18:34
kathancox
kathancox approved these changes Dec 9, 2024
View reviewed changes
Copy link

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple non-blocking nits.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/resources/cluster.md Outdated Show resolved Hide resolved
internal/provider/cluster_resource.go Outdated Show resolved Hide resolved
@fantapop
[CC-30769] remove machine_type from examples
de8a471 
machine_type is not recommended for usage so we remove it from the
examples and replace it with num_virtual_cpus instead.
@fantapop fantapop force-pushed the CC-30769-remove-machine-type-from-examples branch from f06d3cc to de8a471 Compare December 9, 2024 19:01
@fantapop
Copy link
Collaborator Author

fantapop commented Dec 9, 2024

tftrs!

@fantapop fantapop merged commit 5ace3fd into main Dec 9, 2024
4 checks passed
@fantapop fantapop deleted the CC-30769-remove-machine-type-from-examples branch December 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathancox kathancox kathancox approved these changes

@rgcase rgcase rgcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantapop @rgcase @kathancox