[CC-30768] don't allow node_count for serverless cluster #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantapop
commented
Dec 7, 2024
docs/resources/cluster.md
Outdated
| @@ -113,7 +113,7 @@ Required: | |||
|
|
|||
| Optional: | |||
|
|
|||
| - `node_count` (Number) Number of nodes in the region. Will always be 0 for serverless clusters. | |||
| - `node_count` (Number) Number of nodes in the region. Valid for Advance clusters only. | |||
There was a problem hiding this comment.
@kathancox this one should be pretty straightforward. Just this line to check. Thank you!
Previously it was possible to pass in the node_count value for serverless region because the type is shared with dedicated clusters. This ended up causing a state inconsistency however becase node_count is coerced to 0 by the api which conflicts with a value added in the config. To solve this, we simply validate that node_count is not used unless cluster plan is Advanced.
fantapop
force-pushed
the
fantapop/CC-30768-passing-node-count-for-standard-tier-clusters-results-in-state-inconsistency
branch
from
959296d to
49c790a
Compare
rgcase
approved these changes
Dec 9, 2024
kathancox
approved these changes
Dec 9, 2024
fantapop
deleted the
fantapop/CC-30768-passing-node-count-for-standard-tier-clusters-results-in-state-inconsistency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to pass in the node_count value for serverless region because the type is shared with dedicated clusters. This ended up causing a state inconsistency however becase node_count is coerced to 0 by the api which conflicts with a value added in the config. To solve this, we simply validate that node_count is not used unless cluster plan is Advanced.
Commit checklist
make generate)