-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup_config resource #241
Conversation
a5d3496
to
48c107e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments for the doc component of this. I wasn't sure of the constraints here, so feel free to take the comments as you need. I can take another look when you need it.
48c107e
to
5a50b99
Compare
@kathancox I made a round of changes. You can see the diff here: https://github.com/cockroachdb/terraform-provider-cockroach/compare/48c107eae8a9bdc446d998fda84c1b9d1daa4d93..5a50b9916d3b01d54a25b5ee51a051f2d4bc34c9 I think I've incorporated everything but I may have missed something. Please feel free to make more comments if you have further edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The back_config.md doc lgtm
We add the cockroach_backup_config resource to manage backup configuration for clusters.
5a50b99
to
799233f
Compare
I've decided to dedicate a couple hours to exploring this. |
closing in favor of #242 |
Note that this commit is still a work in progress as the final SDK changes required for its use are not deployed yet but I've tested it locally and it's in a good place for feedback.
@mdlinville I was particularly hoping to get your feedback on the documentation that I added. This ended up being a documentation heavy resource.
Commit checklist
make generate
)I'm not super clear on how well the large block of documentation will render on the terraform docs site. Here is the how the value looks with my local rendering. Note: I've updated this screenshot after the latest batch of edits.