migrate testing framework to terraform-plugin-testing #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantapop
force-pushed
the
upgrade-testing-framework
branch
11 times, most recently
from
dd9cd3f to
d411660
Compare
Previously, the terraform provider utilized the sdkv2 framework. In order to stay up to date with testing framework improvements we upgrade to the new terraform-plugin-testing framework following these instructions: https://developer.hashicorp.com/terraform/plugin/testing/migrating The change that instigated this upgrade is that the id field is no longer required in the new framework. During development of the role_grant_resource an ID was not used because the ccapi does not provide it. Rather than working around this using a synthetic ID, we upgrade. Included with this migration are various changes including: * updating github action versions * update code to use new libraries provided by the updated framework. * update to use go 1.21 * fixed some broken examples * integration test changes required by the operation of the new framework. Namely there are different amounts of Read calls made by the new framework. Some tests had call counts encoded into them and need to be updated.
fantapop
force-pushed
the
upgrade-testing-framework
branch
from
d411660 to
66c4c50
Compare
|
@carloruiz / @andy-kimball as recent contributors to the terraform provider, I've added you two here as reviewers. |
|
The changes are separated into 2 commits, one with all the vendor changes. Don't let the 1600+ file counts scare you since its mostly vendor. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the terraform provider utilized the sdkv2 framework. In order to stay up to date with testing framework improvements we upgrade to the new terraform-plugin-testing framework following these instructions:
https://developer.hashicorp.com/terraform/plugin/testing/migrating
The change that instigated this upgrade is that the id field is no longer required in the new framework. During development of the role_grant_resource an ID was not used because the ccapi does not provide an ID for it. Rather than work around this using a synthetic ID, we upgrade.
Commit checklist
make generate)