Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable request logging when debug is enabled #180

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

fantapop
Copy link
Collaborator

@fantapop fantapop commented Mar 3, 2024

Previously, enabling debug for the tf provider did not log out requests. The cloud sdk already supported a debug mode. We now enable this via configuration if one of the terraform debug env vars (TF_LOG_PROVIDER or TF_LOG) are set to either "DEBUG" or "TRACE".

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@fantapop fantapop requested review from pawalt and rgcase March 8, 2024 18:53
Copy link
Contributor

@rgcase rgcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Previously, enabling debug for the tf provider did not log out requests.
The cloud sdk already supported a debug mode. We now enable this via
configuration if one of the terraform debug env vars (TF_LOG_PROVIDER or
TF_LOG) are set to either "DEBUG" or "TRACE".
@fantapop fantapop force-pushed the enable-request-logging-if-debug branch from d3bced2 to e6af236 Compare March 11, 2024 20:07
@fantapop fantapop merged commit 10ccf48 into main Mar 11, 2024
3 checks passed
@fantapop fantapop deleted the enable-request-logging-if-debug branch March 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants