cache: readShard: use a separate mutex #4274
Open
+48
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a separate
readShard
mutex to to protect thereadMap
andeach entry's ref count. This removes the possibility of a couple of
cornercases, making the code much cleaner. We also now avoid
write-locking the entire cache shard when we start a read.
This will also potentially allow moving read buffer management into
readShard
in the future (and having separatereadShard
sets perstore).