metamorphic: skip non-suffixed keys on time-bound iterators #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metamorphic tests sometimes generates iterators with block-property filters constraining the set of MVCC timestamps that should be observed. Previously keys that were not suffixed were guaranteed to always be surfaced. The testkeys block-property collector would map an unsuffixed key to the maximal interval, ensuring any block containing an unsuffixed key would be visited by all time-bound iterators. The cockroachdb block-property collector does not give non-MVCC keys the same treatment. Instead, it simply ignores non-timestamped keys for the purpose of calculating block-property collectors. This results in non-deterministic presence of non-MVCC keys in a time-bound iterators iteration. With the introduction of cockroach kvs in the metamorphic test, we'll need consistent, deterministic behavior. Skipping non-MVCC keys on time-bound iterators ensures the iterator observes the same keys regardless of the behavior of the underlying block property collector.
|
This change is |
RaduBerinde
approved these changes
Jan 21, 2025
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metamorphic tests sometimes generates iterators with block-property filters constraining the set of MVCC timestamps that should be observed. Previously keys that were not suffixed were guaranteed to always be surfaced. The testkeys block-property collector would map an unsuffixed key to the maximal interval, ensuring any block containing an unsuffixed key would be visited by all time-bound iterators.
The cockroachdb block-property collector does not give non-MVCC keys the same treatment. Instead, it simply ignores non-timestamped keys for the purpose of calculating block-property collectors. This results in non-deterministic presence of non-MVCC keys in a time-bound iterators iteration. With the introduction of cockroach kvs in the metamorphic test, we'll need consistent, deterministic behavior. Skipping non-MVCC keys on time-bound iterators ensures the iterator observes the same keys regardless of the behavior of the underlying block property collector.