DOC-15477: Product Change- PR #156905 - sql: Record statement stats for statements executed in UDFs / SPs #21621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… statistics section. In routine-limitations.md, added limitation for statement diagnostics. In statements-views.md, added callout that statements include those executed in UDF/SPs. In transaction-diagnostics.md, added callout about limitation for statement diagnostics.
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Contributor
Author
|
@kyle-a-wong , please review and let me know what is the issue number for the limitation. thanks! |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
kyle-a-wong
reviewed
Dec 15, 2025
|
|
||
| {{site.data.alerts.callout_info}} | ||
| Transaction diagnostics cannot be collected for statements executed within [user-defined functions]({% link {{ page.version.version }}/user-defined-functions.md %}) or [stored procedures]({% link {{ page.version.version }}/stored-procedures.md %}). Transaction diagnostics continue to work only for top-level statement executions. | ||
| {{site.data.alerts.end}} |
Contributor
There was a problem hiding this comment.
I think it would be better phrased as something like: "Transaction diagnostics will not contain a statement diagnostic bundle for statements executed in udfs / sps, but will contain a bundle for the top level udf / sp invocation (or call)"
| These statements will also appear in the [**Transaction details**]({% link {{ page.version.version }}/ui-transactions-page.md %}#transaction-details-page) in the **Statement Fingerprints** table when the stored procedure is invoked as part of a transaction. | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| Statement diagnostics cannot be collected for statements executed within stored procedures. Statement diagnostics continue to work only for top-level statement executions. For details, see [Known limitations](#known-limitations). |
Contributor
There was a problem hiding this comment.
I'm not sure where exactly it should live in this document, but I want to note that statement diagnostics can be requested for the top level UDF / SP statement, and the trace will contain spans for each statement executed. There is just no way (currently) to get specific to have statements executed in the UDF / SP to fulfill an open statement diagnostics request.
| These statements will also appear in the [**Transaction details**]({% link {{ page.version.version }}/ui-transactions-page.md %}#transaction-details-page) in the **Statement Fingerprints** table when the UDF is invoked as part of a transaction. | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| Statement diagnostics cannot be collected for statements executed within UDFs. Statement diagnostics continue to work only for top-level statement executions. For details, see [Known limitations](#known-limitations). |
Contributor
There was a problem hiding this comment.
Same here as i mentioned in the stored procedure doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-15477
Rendered preview