Skip to content

DOC-13170 Product Change- PR #143536 - metric: add /metrics endpoint with static labels #19823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

DOC-13170 Product Change- PR #143536 - metric: add /metrics endpoint with static labels #19823

wants to merge 14 commits into from

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Jun 23, 2025 •
edited
Loading

Fixes DOC-13170

  • Added prometheus-endpoint.md with info about metrics endpoint.
  • In monitoring-and-alerting.md, moved info in the existing Prometheus endpoint section to the new prometheus-endpoint page.
  • In self-hosted-deployments.json, added link to new page.
  • Replaced instances of ({% link {{ page.version.version }}/monitoring-and-alerting.md %}#prometheus-endpoint) and (#prometheus-endpoint) with ({% link {{ page.version.version }}/prometheus-endpoint.md %}).
  • Replace instances of status/vars with Prometheus endpoint.

Rendered preview

@florence-crl
Added prometheus-endpoing.md with info about metrics endpoint.
73b0a01 
In monitoring-and-alerting.md, moved info in the existing Prometheus endpoint section to the new page.

In self-hosted-deployments.json, added link to new page.
@florence-crl
fixed link
ac7ade2
@netlify Netlify
Copy link

netlify bot commented Jun 23, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 70ce316
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68717a55bb574300082e3949

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2025 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented Jun 23, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 70ce316
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68717a551ec2cb00081c32c6

@netlify Netlify
Copy link

netlify bot commented Jun 23, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 70ce316
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68717a55d6ce5100085f705b
😎 Deploy Preview https://deploy-preview-19823--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florence-crl
Merge remote-tracking branch 'origin/main' into DOC-13170
8006302
@florence-crl
Replace instances of ({% link {{ page.version.version }}/monitoring-a…
d7ea811 
…nd-alerting.md %}#prometheus-endpoint) with ({% link {{ page.version.version }}/prometheus-endpoint.md %}).

Replace instances of (#prometheus-endpoint) with ({% link {{ page.version.version }}/prometheus-endpoint.md %}).
@florence-crl
Merge remote-tracking branch 'origin/main' into DOC-13170
a1c92da
@florence-crl
Replace instances of status/vars with Prometheus endpoint.
47ab2a5
kevin-v-ngo
kevin-v-ngo approved these changes Jul 8, 2025
View reviewed changes
Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Prometheus endpoint doc looks great!

florence-crl
florence-crl commented Jul 8, 2025
View reviewed changes
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

dhartunian
dhartunian approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question.

@florence-crl florence-crl requested a review from mikeCRL July 8, 2025 18:45
mikeCRL
mikeCRL requested changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left some suggestions, and questions to potentially consider.

florence-crl
florence-crl commented Jul 11, 2025
View reviewed changes
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeCRL Thanks for the suggestions! please take another look.

@florence-crl florence-crl requested a review from mikeCRL July 11, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian dhartunian approved these changes

@kevin-v-ngo kevin-v-ngo kevin-v-ngo approved these changes

@mikeCRL mikeCRL Awaiting requested review from mikeCRL

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florence-crl @dhartunian @mikeCRL @kevin-v-ngo