DOC-11497 Docs for obs: Enabling troubleshooting hot spots externally (e.g., logs or metrics) #19577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
commented
Jun 3, 2025
There was a problem hiding this comment.
thanks for the first look, @angles-n-daemons please review again.
angles-n-daemons
approved these changes
Jun 5, 2025
kevin-v-ngo
requested changes
Jun 16, 2025
There was a problem hiding this comment.
Few questions and suggestions,
- Can we simplify this and remove the second box ("Is there a node outlier in the metrics?")?
- Are guaranteed to have a 'hot ranges log' when there is a popular key log for the latch contention workflow? CC @angles-n-daemons
There was a problem hiding this comment.
modified diagram
src/current/v25.2/detect-hotspots.md
Outdated
| - Once you identify a relevant log, note the range ID in the tag section of the log. | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| There may be false positives of the `popular key detected` log. |
There was a problem hiding this comment.
How? If we determined that there is a metric anomaly in latch or CPU, don't we remove the false positives?
There was a problem hiding this comment.
@angles-n-daemons Would you be able to answer the above questions?
florence-crl
commented
Jun 17, 2025
There was a problem hiding this comment.
@kevin-v-ngo thanks for your first review, please take a second look.
There was a problem hiding this comment.
modified diagram
src/current/v25.2/detect-hotspots.md
Outdated
| - Once you identify a relevant log, note the range ID in the tag section of the log. | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| There may be false positives of the `popular key detected` log. |
There was a problem hiding this comment.
@angles-n-daemons Would you be able to answer the above questions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-11497
Added detect-hotspots.md and associated images.
Rendered previews: