Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-8959

@rmloveland
Copy link
Contributor Author

see also: cockroachdb/cockroach#111629

@github-actions
Copy link

github-actions bot commented Mar 10, 2025

Files changed:

@rmloveland rmloveland requested a review from dikshant March 10, 2025 18:24
@netlify
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 72dd530
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67d9b50e5172b30008c4d583

@netlify
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 72dd530
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67d9b50efecf0f00081d1404

@rmloveland
Copy link
Contributor Author

@dikshant i made this a "known limitation", please let me know what you think

once the content changes to v25.1 are reviewed, i will backport them to earlier versions

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@netlify
Copy link

netlify bot commented Mar 10, 2025

Netlify Preview

Name Link
🔨 Latest commit 72dd530
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67d9b50e2645d800083ba5c7
😎 Deploy Preview https://deploy-preview-19436--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmloveland rmloveland requested a review from taroface March 10, 2025 18:52
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions; generally LGTM

Fixes DOC-8959

NB. This PR includes backported changes to v23.*, v24.*, and v25.*
@rmloveland rmloveland force-pushed the 20250310-DOC-8959-secondary-region-and-rbr-tables-dont-mix branch from 1afc17d to eb107a0 Compare March 18, 2025 17:58
@rmloveland rmloveland enabled auto-merge (squash) March 18, 2025 18:01
@rmloveland rmloveland merged commit a084061 into main Mar 18, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250310-DOC-8959-secondary-region-and-rbr-tables-dont-mix branch March 18, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants