Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of incremental backups with locality aware #19398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katmayb
Copy link
Contributor

@katmayb katmayb commented Feb 24, 2025

Fixes DOC-12344

Adjust the sentence in v24.3 + v25.1 regarding locality-aware incremental backups to clarify that the the storage URI + the COCKROACH_LOCALITY region must match the related full backup.

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 533a2d2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67bca859af555000081caa33

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 533a2d2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67bca859d4062e00080148d4

Copy link

netlify bot commented Feb 24, 2025

Netlify Preview

Name Link
🔨 Latest commit 533a2d2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67bca8599a0ba400089bb81e
😎 Deploy Preview https://deploy-preview-19398--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katmayb katmayb requested a review from kev-cao February 24, 2025 17:27
@katmayb
Copy link
Contributor Author

katmayb commented Feb 24, 2025

@kev-cao I applied the proposed changes to v24.3 + v25.1 with the removal of the old syntax — is that correct? Or, does the change need to apply to other versions?

@@ -130,7 +130,7 @@ To restore from a specific backup, use [`RESTORE FROM {subdirectory} IN ...`]({%

## Create an incremental locality-aware backup

If you backup to a destination already containing a [full backup]({% link {{ page.version.version }}/take-full-and-incremental-backups.md %}#full-backups), an [incremental backup]({% link {{ page.version.version }}/take-full-and-incremental-backups.md %}#incremental-backups) will be appended to the full backup in a subdirectory. When you're taking an incremental backup, you must ensure that the incremental backup localities match the full backup localities otherwise you will receive an error. Alternatively, take another full backup with the matching localities before running the incremental backup.
If you back up to a destination already containing a [full backup]({% link {{ page.version.version }}/take-full-and-incremental-backups.md %}#full-backups), an [incremental backup]({% link {{ page.version.version }}/take-full-and-incremental-backups.md %}#incremental-backups) will be appended to the full backup in a subdirectory. To take a locality-aware incremental backup and restore from it successfully, you must maintain the same storage URI and `COCKROACH_LOCALITY` mappings that were established by the corresponding full backup. Alternatively, take another full backup with the matching localities and URIs before running the incremental backup.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some confusion/ambiguity with my answer in Slack. The incremental mappings don't have to match the full backup mappings, they just have to be consistent. So if with one BACKUP command you have incremental_location = ('foo?region=us-east', 'bar?region=us-west', 'baz?region=us-central'), then that mapping must be maintained for all incrementals in that chain. @dt if you could confirm this behavior that'd be helpful!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kev-cao, are you only to referring to incremental_location in your comment here? Or, all incrementals? I haven't changed the text for the incremental_location option on this page. This update is only referring to regular incrementals — so I want to check whether I need to adjust the edits I've made or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants