Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on transparent huge pages (THP) setting #19343

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-12097

@rmloveland
Copy link
Contributor Author

@RaduBerinde i added this to v25.1 docs so we can verify language

what previous versions should also have this guidance?

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d0ae773
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67bcd9bb04d74200081d4e43

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d0ae773
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67bcd9bb5488f5000819cea4

Copy link

netlify bot commented Feb 4, 2025

Netlify Preview

Name Link
🔨 Latest commit d0ae773
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67bcd9bb57786b0008c80f28
😎 Deploy Preview https://deploy-preview-19343--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmloveland
Copy link
Contributor Author

rmloveland commented Feb 6, 2025

@RaduBerinde this may go without saying but I guess since this docs change is about the OS config it can be backported to v23.1+ docs? (once we're happy with it)

or are there CRDB-version-related considerations?

please advise, thanks!

@RaduBerinde
Copy link
Member

Looks great! Yes, we should backport.

@rmloveland rmloveland requested a review from taroface February 11, 2025 17:23
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but couple suggestions

@rmloveland rmloveland enabled auto-merge (squash) February 24, 2025 20:42
@rmloveland rmloveland merged commit e6d0fe2 into main Feb 24, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250204-DOC-12097-transparent-huge-pages branch February 24, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants