Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GRANT EXECUTE to SECURITY DEFINER function example; number steps #19342

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

taroface
Copy link
Contributor

@taroface taroface commented Feb 4, 2025

Added GRANT EXECUTE to the SECURITY DEFINER function example steps. This example currently works without the explicit grant only because it happens to be created on the public schema. See PG docs.

@taroface taroface requested a review from DrewKimball February 4, 2025 18:28
Copy link

github-actions bot commented Feb 4, 2025

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit fa43149
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67a6640a0ecbe70008b9a8e1

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit fa43149
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67a6640af58dfc00080a8db5

Copy link

netlify bot commented Feb 4, 2025

Netlify Preview

Name Link
🔨 Latest commit fa43149
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67a6640a36843000092d7a6f
😎 Deploy Preview https://deploy-preview-19342--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM with one suggestion.

src/current/v24.3/create-function.md Show resolved Hide resolved
src/current/v24.3/create-function.md Show resolved Hide resolved
@taroface taroface requested a review from florence-crl February 7, 2025 15:07
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taroface taroface enabled auto-merge (squash) February 7, 2025 19:50
@taroface taroface merged commit 7965be2 into main Feb 7, 2025
6 checks passed
@taroface taroface deleted the fix-security-definer-example branch February 7, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants