Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the code block on LDAP page #19328

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix the code block on LDAP page #19328

merged 2 commits into from
Jan 29, 2025

Conversation

katmayb
Copy link
Contributor

@katmayb katmayb commented Jan 29, 2025

Quick fix to a code block that wasn't rendering

Copy link

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit b14613c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/679aa8c23e494800080083a7

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit b14613c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/679aa8c2d6f2470008c42859

Copy link

netlify bot commented Jan 29, 2025

Netlify Preview

Name Link
🔨 Latest commit b14613c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/679aa8c29ede2f0008b06b76
😎 Deploy Preview https://deploy-preview-19328--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katmayb katmayb requested a review from rmloveland January 29, 2025 15:17
@@ -141,7 +141,7 @@ To create users in bulk:
cockroach sql --file=create_users.sql --host=<servername> --port=<port> --user=<user> --database=<db> --certs-dir=path/to/certs
~~~

To update users on an ongoing basis, you could script the required [`CREATE ROLE`]({% link {{ page.version.version }}/create-role.md %}), [`DROP ROLE`]({% link {{ page.version.version }}/drop-role.md %}), or [`GRANT`]({% link {{ page.version.version }}/grant.md %}) commands to be [executed]({% link {{ page.version.version }}/cockroach-sql.md %}#general) as needed. For example:
To update users on an ongoing basis, you could script the required [`CREATE ROLE`]({% link {{ page.version.version }}/create-role.md %}), [`DROP ROLE`]({% link {{ page.version.version }}/drop-role.md %}), or [`GRANT`]({% link {{ page.version.version }}/grant.md %}) commands to be [executed]({% link {{ page.version.version }}/cockroach-sql.md %}#general) as needed. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathancox Happened to spot this PR. Thanks for addressing. I think we actually need to leave this unindented, but also unindent the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, updated per your comment! Thanks

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katmayb katmayb merged commit 523e3d4 into main Jan 29, 2025
6 checks passed
@katmayb katmayb deleted the quick-fix-ldap branch January 29, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants